290 eol upgrade lasted version #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorcery#171) * Remove before_install entirely from travis.yml per @BanzaiMan feedback * Fix version conflict with Rails 4 gemfiles Rails 4 requires bundler <2.0, but Rails 4 is on the way out, and Rails 6 is on the horizon. I think it makes sense to drop support rather than fight the TravisCI configuration between versions. * Update CHANGELOG.md
…#163) * Fix engine initializer * Update controller callbacks to safeguard against double inclusion * Update sqlite3 dependency per TravisCI error
* Add magic_login to initializer comments * Clean up initializer comments
* Add #change_password method to reset_password module. Serves the same function as `#change_password!` but without raising exceptions on save. Useful for returning validation errors back to the view, for example, when `:password_confirmation` did not match `:password`. * Update documentation. * Rework tests per review comments. * Clarify what's happening with save methods in specs.
* Introduce pepper option (currently available with BCrypt) Before this change, config option 'salt_join_token' has been ignored when BCrypt is chosen as crypto-provider (default). This patch introduces its alternative option that allows users to add app-specific secret token with BCrypt. To ensure compatibility, this change only takes place when the new option 'pepper' is provided, and does NOT affect on those who have already set salt_join_token. * fix typos and remove an unnecessary block * add test to describe behaviors with empty-string pepper
* line provider * require line provider * spec * fix response params * set state * fix spec
* Update changelog * Update LinkedIn provider to use OAuth2 per v1 deprecation * Update changelog
* Allow for custom providers with multi-word class names. Currently sorcery will not handle custom providers with names like: ExampleProvider. config.example_provider would search for a class called Example_provider rather than ExampleProvider. Using .classify rather than .capitalize will fix this. I've added an example provider implementation under the spec/support directory, and have a test that ensures that it is loaded properly via config. The existing tests for existing providers are also coming back with successes. * Add spec to cover single-word custom providers
* Used user email address from LinkedIn * Update example user_info_mapping in initializer * Force r_emailaddress in @scope in linkedin provider * Load email only if r_emailaddress is in scope * Adjust initializers Linkedin comment
(previous code skipped XHR requests, but not all JSON requests are XHR)
* Use id instead of uid for VK provider * fix specs
* Remove MySQL database creation call * Add missing manifest.js file * Wrong config folder...
* add discord provider * add initializer comment * add discord spec
* Calling ActionController::Base causes deprecation warnings due to autoloading. ActionController::Base is autoloaded by Rails when called from the initializer in engine.rb which causes Rails 6 to raise deprecation warnings. * Added an empty manifest.js for specs The latest version of sprockets (4.0.0) now requires a manifest.js file in ‘app/assets/config/‘ or else an Exception is raised. * Deprecate Ruby Versions <= 2.3.x Per the following article, ruby versions 2.3 and below are deprecated: https://www.ruby-lang.org/en/news/2019/03/31/support-of-ruby-2-3-has-ended/ Ruby 2.4 will also be deprecated and should be removed by March 31, 2020. * Update Ruby 2.5.x to latest version (2.5.7)
* Fix typo * Fix 'an' to 'a'
…thod instead of checking inheritance from `ActionMailer` (Sorcery#211) * Check if mail object responds to delivery method Instead of checking for an inheritance of ActionMailer::Base, just see if the conffigure mailer and method respond to the configured delivery method. Since both the mailer and the willingniess to automatically send out messages can be configured, the message should be send if it is sendable, regardless of which Class the configured mailer inherits from. * Add empty mainifest.js to rails_app Not having a manifest was causing issues running `bundle exec rake` with sprockets 4.
The authenticate method previously would return before callbacks executed if an invalid password was provided, which causes the brute force protection to only work for the first lockout period, and only resets after a successful login. Fixes Sorcery#231
Signed-off-by: Steven Hoffman <[email protected]>
* Update mongoid adapter to use splat operator for options * Add changelog entry
Its presence causes 'invalid_auth' error because Slack API now requires token to be passed in Authorization header. Co-authored-by: Simon Bennett <[email protected]>
…rcery#293) * Fix valid_password? not using configured values when called alone * Make set_encryption_attributes a public method (will be removed in v1) * Remove unused instance method * Update changelog
I'm really hoping this only runs against the main branch, but suspect it might run against _everything_ daily...Will tune once I better understand how it interacts.
* Update Github templates to use comments * Update Github actions version matrix * Temporarily disable Ruby 3.1 and Rails 7 testing. (not yet supported)
… with plural names (Sorcery#305) * Fix the way the external provider class is instantiated * added a spec * Updated changelog * Fixed mistake in changelog * Add changelog additions under HEAD instead of under new version number.
* adapt to Rails 7.0 defaults Since 7.0, Rails protects against redirecting to external hosts https://api.rubyonrails.org/classes/ActionController/Redirecting.html#method-i-redirect_to-label-Open+Redirect+protection This change adapts to this by adding the option `allow_other_host` to the method call * fill in changelog
* Update version lock for oauth2 to v2 per v1 deprecation * Add changelog entry for oauth2 update
…Sorcery#333) * Raise ArgumentError when calling change_password! with blank password * Add CHANGELOG entry
…cery#341) * Update auth_scheme to oauth2 v1 defaults per v2 breaking changes * Update CHANGELOG.md
Update contact details
Username changed, updating to reflect that.
hoangth-dipro
force-pushed
the
290-eol_upgrade_lasted_version
branch
2 times, most recently
from
afd7e70 to
da1a1aa
Compare
hoangth-dipro
force-pushed
the
290-eol_upgrade_lasted_version
branch
from
da1a1aa to
0947a41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#アップグレード