Clean up initializer comments #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your help @valentine! I'll review this when I have some time and merge it in. Any other help with the documentation is greatly appreciated. :) |
joshbuker
approved these changes
Mar 16, 2019
| # Default: `:uid` | ||
| # | ||
| # user.provider_uid_attribute_name = | ||
| end | ||
|
|
||
| # This line must come after the 'user config' block. | ||
| # Define which model authenticates with sorcery. | ||
| config.user_class = '<%= model_class_name %>' | ||
| config.user_class = "<%= model_class_name %>" |
There was a problem hiding this comment.
Personally I prefer single quotes for strings that do not require interpolation. Not a blocking issue however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to make the documentation in the
initializer.rbfile (which gets copied toconfig/sorcery.rbon install) clearer for new users.I've also added the
magic_loginsubmodule to the list, since that seems like a recent addition.