-
Notifications
You must be signed in to change notification settings - Fork 231
Support the LINE login auth #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you describe what line is? |
@Ch4s3 |
@athix Should we try to push this to an external gem or roll it in? |
Sorry for the late reply, I think we should probably roll in any OAuth providers that are fully ready until the gem split is complete. That said, splitting the external providers into its own gem should probably happen sooner rather than later. @Ch4s3 perhaps we should set a time for discussion on the state of Sorcery and our near-term plans for it? |
@athix |
@ebihara99999 and @athix let's keep this discussion moving and make a decision soon. |
Are there plans to merge this PR? |
@lion-man44 I'll update this and merge it in when I get the chance. I think I still need to do a release for the callback issue, so this can just be rolled into that update. |
@athix Thank's for repling. By the way, are there any workarounds? (Edit) Sorry, this PR is workaround. |
@lion-man44 you should now be able to read off master as a work-around. Actual release coming soon™. |
@athix Thank you very good news! |
I propose a new provider for LINE login authentication with auth2.0.
https://developers.line.me/line-login/overview
This PR offers only the minimal features.