Skip to content

Conversation

@stefanistrate
Copy link
Contributor

Resolves #3275.

@mwaskom
Copy link
Owner

mwaskom commented Feb 24, 2023

Thanks; seems reasonable aside from one nit, though a test would be nice too...

Co-authored-by: Michael Waskom <[email protected]>
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #3276 (8374046) into master (3733590) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3276   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files          77       77           
  Lines       24696    24705    +9     
=======================================
+ Hits        24297    24306    +9     
  Misses        399      399           
Impacted Files Coverage Δ
seaborn/matrix.py 96.18% <100.00%> (ø)
tests/test_matrix.py 97.69% <100.00%> (+0.02%) ⬆️

@stefanistrate
Copy link
Contributor Author

Thanks; seems reasonable aside from one nit, though a test would be nice too...

Thanks for suggestion. I'll add a test soon.

@stefanistrate
Copy link
Contributor Author

I've just added a test that fails before my change and passes after. Please take another look.

@mwaskom
Copy link
Owner

mwaskom commented Feb 25, 2023

Test looks perfect, thanks!

@mwaskom mwaskom merged commit 8735494 into mwaskom:master Feb 25, 2023
@stefanistrate stefanistrate deleted the fix-heatmap-norm-issue branch February 25, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

heatmap(..., norm=None, ...) has different behaviour than without specifying the norm argument

2 participants