Feature implementation from commits 72faf27..7231fc2 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RS headers set. (mwaskom#3234) * Change required for mwaskom/seaborn-data#24 * Remove DATASET_NAMES_URL from public api * Minor cleanup * Cleanup data * Change according to review * Remove unused import
* WIP modernize barplot * Fix orient conditionals in Beeswarm * Improve empty data robustness * Don't use itertools to parameterize tests * Update test that assumed unnecessary dodge * Add barplot to common categorical tests * Add a number of barplot tests, not all passing * Fix barplot hue processing * Accept x/y as orient in categoricals and use internally * Add new 'flat' behavior for barplot * Add legend for barplot * More barplot tests * Fix dodge inference * Update orient comparisons in legacy category plots * Declare bar as a refactored kind in catplot * Update infer_orient tests * Get basic catplot with new bar code functional * Matplotlib backcompat in tests * Add tests for error caps * Fix stacklevel parameter * Add hue order/norm tests and improve docs * Update barplot API docs * Fix capsize and linewidth, handle na grouping data * Define (failing) tests for native scale dodging * More tests for minor parameters * Fix log-scaled capsizes * MPL backcompat in tests * Update tests to reflect new default color behavior * Deprecate errcolor and errwidth in favor of a full err_kws dict * Improve barplot color deprecation warnings * Add tests for barplot vs catplot with identical parameters
…malization (mwaskom#3267) * Refactor countplot to use common infra and add stat parameter * Update countplot docstring * Don't use shared tests that assume x/y signature * Improve test coverage
* Add basic refactored version of pointplot * Add basic legend and update tests for no scatter artist * Add unit tests for new pointplot * Test approximate quality with log dodge * Refactor relational legend setup * Allow common and synced kwargs to be used in legend * Further refactoring of hacky lengend code * Add tests for pointplot legend * Refactor legend configuration code * Update catplot to use new point plotting * Update pointplot docstring * Skip legend tests on old matplotlib * Handle backcompat for deprecated kwargs in catplot * Enhance pairplot docstring
Change `paltte` to `palette`.
* Remove vestigial bar/point/countplot code * Remove errant print statement
* Fix heatmap issue. * Update seaborn/matrix.py Co-authored-by: Michael Waskom <[email protected]> * Fix condition * Add test for explicit `norm=None`. --------- Co-authored-by: Michael Waskom <[email protected]>
* Avoid mpl37 warnings * Avoid mpl37 warnings in categorical tests
* Refactor most boxplot functionality, save for dodging * Get accurate widths on a log orient scale * Define a BoxPlotContainer to hold boxplot artists * Fix line_color edgecase * Set up basic tests * Add some basic boxplot testing infra * Add a number of boxplot tests * Allow more boxplot overrides and add more tests * Update boxplot docstring * Represent individual boxes in BoxPlotContainer with a namedtuple * Use new boxplot backend in catplot * Remove vestigial boxplot code * Add boxplot/catplot tests * Don't show a legend by default with redundant hue * Fix notch * MPL backcompat in the way we test PathPatch vertices * Clear boxplot docstring notebook * Add some tests for the BoxPlotContainer * Update boxplot API docs * Set the solid_captyle of median/whisker lines so they don't extend past box when thick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes from a range of commits from the original repository.
Commit Range:
72faf27..7231fc2Files Changed: 25 (19 programming files)
Programming Ratio: 76.0%
Commits included:
norm=Noneissue (Fix heatmapnorm=Noneissue mwaskom/seaborn#3276)... and 5 more commits