Skip to content

Fix heatmap norm=None issue #3276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 25, 2023
Merged

Fix heatmap norm=None issue #3276

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da42aa3
Fix heatmap issue.
stefanistrate Feb 23, 2023
c29b00a
Update seaborn/matrix.py
stefanistrate Feb 24, 2023
8caa0e6
Fix condition
stefanistrate Feb 25, 2023
8374046
Add test for explicit `norm=None`.
stefanistrate Feb 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion seaborn/matrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ def plot(self, ax, cax, kws):

# setting vmin/vmax in addition to norm is deprecated
# so avoid setting if norm is set
if "norm" not in kws:
if "norm" not in kws or not kws["norm"]:
kws.setdefault("vmin", self.vmin)
kws.setdefault("vmax", self.vmax)

Expand Down