Skip to content

Port recent xml fixes to 4.3 #22070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Apr 2, 2024
Merged

Port recent xml fixes to 4.3 #22070

merged 32 commits into from
Apr 2, 2024

Conversation

miiizen
Copy link
Contributor

@miiizen miiizen commented Mar 26, 2024 •
edited by its-not-nice
Loading

miiizen added 29 commits March 26, 2024 14:22
@miiizen
Only set line to below if explicit in XML
1752053
@miiizen
Align harmony to the top & centre when attached to fret diagram
d466ea7
@miiizen
Use correct track for melisma length on XML import
b1cc6d4
@miiizen
Read lyric elision tags in XML files
d21fe18
@miiizen
Read and write placement information for lyrics
a1080db
@miiizen
Create HBox before codas on XML import
3e567c9
@miiizen
Find Sibelius metronome marks which have been exported incorrectly
a3451db
@miiizen
Remove spaces between note and dot in imported tempo text
1d89f20
@miiizen
Scale header and footer font size to fit within margins
5a9b812
@miiizen
Read XML other-notation tag
b2471f0
@miiizen
Read XML <symbol> tag
85147be
@miiizen
Read XML other-direction tag
122fa11
@miiizen
Fix ottavas imported from Sibelius
2cce19a
@miiizen
Set fermata direction if none is specified
6b7b1d5
@miiizen
Add lyrics on grace notes to their parent notes instead on XML import
bf0fe41
@miiizen
Correct caesura placement & add unsupported sib output
3c23517
@miiizen
Set hairpin's default placement to above the stave on XML import
3c9f8ef
@miiizen
Set lyric position precisely on XML import
e320677
@miiizen
Import and export cross voice arpeggios correctly
d57fa0e
@miiizen
Add arpeggios on rests to the next available chord on XML import
e73d619
@miiizen
Set line position to above or below as we do for other directions
b082750
@miiizen
Add infer text type checkbox to XML import dialogue
ac7c610
@miiizen
Port infer source subtitle
6bf3bcb 
c17e326
@miiizen
Port refine credit inference regex
259b7ab 
ffc6ba8
@miiizen
Port hide redundant header text
404c1d8 
cf8820c
@miiizen
Port prevent collisions with inferred credits
dbd987a 
Port adjust line spacing of reformatted header VBox

fe21b7f
ba0c848
@miiizen
Port extend subtitle inference cases
ba7868a 
8fa249d
@miiizen
Port Delete staff text that is meant for footer
59596ec 
493c727
@miiizen
Port add further header text inference cases
3cad731 
b6d183f
@RomanPudashkin
Copy link
Contributor

@miiizen please fix the failed tests

@RomanPudashkin
Copy link
Contributor

Please add this fix to your PR

@RomanPudashkin RomanPudashkin merged commit 5f6178a into musescore:4.3.0 Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RomanPudashkin RomanPudashkin RomanPudashkin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@miiizen @RomanPudashkin