Import ottavas from Sibelius correctly #21499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorkorsukov
force-pushed
the
master
branch
6 times, most recently
from
fa1f8d3 to
525a11a
Compare
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 14, 2024
| while (m_e.readNextStartElement()) { | ||
| if (m_e.name() == "software") { | ||
| m_exporterString += m_e.readText(); | ||
| m_exporterString += m_e.readText().toLower(); |
There was a problem hiding this comment.
This doesn't mix and match with
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 14, 2024
miiizen
force-pushed
the
xml-ottava-sib
branch
from
56723d1 to
b9e114f
Compare
its-not-nice
approved these changes
Feb 14, 2024
miiizen
force-pushed
the
xml-ottava-sib
branch
from
b9e114f to
47aaf36
Compare
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 14, 2024
mike-spa
approved these changes
Feb 16, 2024
| String m_sndFine; | ||
| String m_sndSegno; | ||
| String m_sndToCoda; | ||
| bool visible = true; |
Comment on lines
3215
to
3216
| std::map<String, SymId> otherDirectionSyms; | ||
| otherDirectionSyms = { { String(u"Rhythm dot"), SymId::augmentationDot }, |
There was a problem hiding this comment.
For now, maybe nicer to do this one like this:
Suggested change
| std::map<String, SymId> otherDirectionSyms; | |
| otherDirectionSyms = { { String(u"Rhythm dot"), SymId::augmentationDot }, | |
| static const std::map<String, SymId> otherDirectionSyms = { { String(u"Rhythm dot"), SymId::augmentationDot }, |
| delete desc.sp; | ||
| } else { | ||
| if (spdesc.isStarted) { | ||
| if (spdesc.sp && spdesc.sp->isOttava() && delayOttava) { |
There was a problem hiding this comment.
Is it correct that you don't need to check spdesc.isStarted here?
There was a problem hiding this comment.
It is the else branch of if (spdesc._isStopped), can it have a 3rd state?
There was a problem hiding this comment.
@cbjeukendrup I probably ought to, it can't hurt to be safe
|
And a rebase is needed |
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 24, 2024
miiizen
force-pushed
the
xml-ottava-sib
branch
from
47aaf36 to
d0f04d5
Compare
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 26, 2024
cbjeukendrup
approved these changes
Feb 27, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 27, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 9, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sibelius exports its ottavas inconsistently with other programs - ottava tags should start before the notes under the ottava, and finish after the last note. Sibelius stops before, leaving the ottava a note short. This PR delays adding ottavas until the following note if the score was exported from Sibelius.
Before:
After:
(Depends on the commit identiying exporter software 2978b7b in #21483)