Correct caesura placement & add unsupported sib output #21734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 28, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 28, 2024
its-not-nice
approved these changes
Feb 29, 2024
mike-spa
approved these changes
Mar 1, 2024
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 28, 2024
incl. exporting their color and placement, color gets ignored on import though and placement needs to get set to above explicitly, to not end up below. As caesuras now cause Mu3 to fail on importing quite miserably, an option for compatibility got added. Needs one line from musescore#21734 to fix failing unit tests reg caesura placement
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 28, 2024
incl. exporting their color and placement, color gets ignored on import though and placement needs to get set to above explicitly, to not end up below. As caesuras now cause Mu3 to fail on importing quite miserably, an option for compatibility got added. Needs one line from musescore#21734 to fix failing unit tests reg. caesura placement.
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 28, 2024
incl. exporting their color and placement, color gets ignored on import though and placement needs to get set to above explicitly, to not end up below. Don't really export caesuras though, as anything before 3.7 can't import those, but reports corrupptions and imports all subsequent measures entirel empty. Needs one line from musescore#21734 to fix failing unit tests reg. caesura placement.
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 28, 2024
incl. exporting their color and placement, color gets ignored on import though and placement needs to get set to above explicitly, to not end up below. Don't really export caesuras though, as anything before 3.7 can't import those, but reports corrupptions and imports all subsequent measures entirel empty. Needs one line from musescore#21734 resp. #348 to fix failing unit tests reg. caesura placement.
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 28, 2024
incl. exporting their color and placement, color gets ignored on import though and placement needs to get set to above explicitly, to not end up below. As caesuras now cause Mu3 to fail on importing quite miserably, an option for compatibility got added. Needs one line from musescore#21734 to fix failing unit tests reg. caesura placement.
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 28, 2024
incl. exporting their color and placement, color gets ignored on import though and placement needs to get set to above explicitly, to not end up below. As caesuras now cause Mu3 to fail on importing quite miserably, an option for compatibility got added. Needs one line from musescore#21734 to fix failing unit tests reg. caesura placement.
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 6, 2024
incl. exporting their color and placement, color gets ignored on import though and placement needs to get set to above explicitly, to not end up below. As caesuras now cause Mu3 to fail on importing quite miserably, an option for compatibility got added. Needs one line from musescore#21734 to fix failing unit tests reg. caesura placement.
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 6, 2024
incl. exporting their color and placement, color gets ignored on import though and placement needs to get set to above explicitly, to not end up below. As caesuras now cause Mu3 to fail on importing quite miserably, an option for compatibility got added. Needs one line from musescore#21734 to fix failing unit tests reg. caesura placement.
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 6, 2024
incl. exporting their color and placement, color gets ignored on import though and placement needs to get set to above explicitly, to not end up below. As caesuras now cause Mu3 to fail on importing quite miserably, an option for compatibility got added. Needs one line from musescore#21734 to fix failing unit tests reg. caesura placement.
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 9, 2024
incl. exporting their color and placement, color gets ignored on import though and placement needs to get set to above explicitly, to not end up below. As caesuras now cause Mu3 to fail on importing quite miserably, an option for compatibility got added. Needs one line from musescore#21734 to fix failing unit tests reg. caesura placement.
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 9, 2024
incl. exporting their color and placement, color gets ignored on import though and placement too, but needs to get set as per voice explicitly, to not end up below. Anything before 3.7 can't import those caesuras (except the "normal" one), but reports corruptions and imports all subsequent measures entirely empty. Needs one line from musescore#21734 resp. #348 to fix failing unit tests reg. caesura placement.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 9, 2024
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 10, 2024
incl. exporting their color and placement, color gets ignored on import though and placement needs to get set to above explicitly, to not end up below. As caesuras now cause Mu3 to fail on importing quite miserably, an option for compatibility got added. Needs one line from musescore#21734 to fix failing unit tests reg. caesura placement.
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 12, 2024
incl. exporting their color and placement, color gets ignored on import though and placement needs to get set to above explicitly, to not end up below. As caesuras now cause Mu3 to fail on importing quite miserably, an option for compatibility got added. Needs one line from musescore#21734 to fix failing unit tests reg. caesura placement.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 15, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 15, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 15, 2024
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 17, 2024
incl. exporting their color and placement, color gets ignored on import though and placement too, but needs to get set as per voice explicitly, to not end up below. Anything before 3.7 can't import those caesuras (except the "normal" one), but reports corruptions and imports all subsequent measures entirely empty. Needs one line from musescore#21734 resp. #348 to fix failing unit tests reg. caesura placement.
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 17, 2024
incl. exporting their color and placement, color gets ignored on import though and placement needs to get set to above explicitly, to not end up below. As caesuras now cause Mu3 to fail on importing quite miserably, an option for compatibility got added. Needs one line from musescore#21734 to fix failing unit tests reg. caesura placement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: image
Also adds support for caesuras exported as tags