[core] Add CI check that the PR has label #32886
Conversation
mnajdova
added
the
internal
|
@DanailH is this something you want in the X too? It is blocking the PR from being merged if no label is added. |
Yes, it looks like a useful limitation. I will duplicate the logic, open a PR and add you as a reviewer ;) |
|
@mnajdova Regarding the build duration. In https://github.com/mui/material-ui/runs/7714987097?check_suite_focus=true, it has spent 41s to build the action. By that time, I have moved to a different tab. I didn't notice in #33843 that I forgot the label. It would be better if it was running faster. I have found mheap/github-action-required-labels#2 (comment) and in practice, it's x10 faster for him: https://github.com/Kong/docs.konghq.com/runs/7701337497?check_suite_focus=true, 4s. As far as I have looked at it, the problem is with the release. Compare the content of https://github.com/mnajdova/github-action-required-labels/releases/tag/v2.0 with the content of https://github.com/mheap/github-action-required-labels/releases/tag/v2.1.0. In our case, we rebuild the action for each run. In his case, he has the output of the action build 😁 |
|
Nice catch Olivier, it was exactly as you said. I've published v2.1.0 for the action (I thought I would need to also update our yml but it seems to have picked up the updated version). I've tried in #33795, it finished in 2s :)
|
5 participants
Tested in dimovi91#10, but apparently can also be tested on the PR itself :))
For the check, I've forked https://github.com/mheap/github-action-required-labels and added option for checking just minimum num of labels without needing to specify list of labels that should be applied.