[Alert] Constrain message width and allow overflow #32747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
reviewed
May 18, 2022
There was a problem hiding this comment.
Nice, let's add a regression test for it. It should live here - https://github.com/mui/material-ui/tree/master/test/regressions/fixtures/Alert
mnajdova
approved these changes
Jun 3, 2022
oliviertassinari
added
type: bug
|
I've definitely seen CI break on my last two PRs because of missing labels |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduction: https://codesandbox.io/s/actionalerts-material-demo-forked-7fi9zq?file=/demo.tsx
Got hit by this while displaying stack traces in an
Alert.