[build] Avoid types generation from interferring with itself (alternative to 30200) #30201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Janpot
changed the title
github-actions
bot
added
the
PR: out-of-date
|
See #30200 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another way to solve #30200
Just remove the
-bflag to avoid referenced projects from being built. It will keep using thebuildTypesscript for each package. But this requireslernato build the packages in order, so we can't use the--parallelflag. Let's see what the impact is on performance.We could look into using https://turborepo.org/ to maximize parallelization of these build scripts.