Skip to content

Conversation

michelengelen
Copy link
Member

The check type label workflow did not get triggered on updates to the PR HEAD, so it was stuck in an unresolved state.

This should fix it.

@michelengelen michelengelen self-assigned this Aug 26, 2025
@michelengelen michelengelen added type: bug It doesn't behave as expected. scope: support-infra Involves the support-infra product (https://www.notion.so/mui-org/1a4cbfe7b660809c8896d534a9c7d50f). labels Aug 26, 2025
@mui-bot
Copy link

mui-bot commented Aug 26, 2025

Deploy preview: https://deploy-preview-19342--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 🔺+5B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 🔺+4B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 🔺+2B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 🔺+7B(+0.01%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 🔺+3B(+0.01%)

Details of bundle changes

Generated by 🚫 dangerJS against 5ce0bd0

@michelengelen michelengelen merged commit 22c79bb into mui:master Aug 26, 2025
24 checks passed
@oliviertassinari oliviertassinari changed the title [infra] Add synchronize to workflow triggers [support-infra] Add synchronize to workflow triggers Aug 26, 2025
@oliviertassinari
Copy link
Member

Nice 👍, the CI is tied to a commit, so it needs to run on each.

With the initial GitHub Action (mui/material-ui#32886), we did https://github.com/mui/material-ui/blob/41da88f24d0c2a2ccb5480a95d352a6650607080/.github/workflows/check-if-pr-has-label.yml#L5, but this is a fork of https://github.com/mheap/github-action-required-labels?tab=readme-ov-file#complete-example, which does it correctly like in this PR.

I have updated mui/mui-public#206 to flag that check-if-pr-has-label.yml is now legacy, it's replaced with our new .github/workflows/check-if-pr-has-type-label.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: support-infra Involves the support-infra product (https://www.notion.so/mui-org/1a4cbfe7b660809c8896d534a9c7d50f). type: bug It doesn't behave as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants