Skip to content

Conversation

@sunag
Copy link
Collaborator

@sunag sunag commented Jun 19, 2025

Related issue: #31059 (comment), #30837 (comment), #31271

Description

Introduce tangentViewFrame, bitangentViewFrame and fixed the incompatibilities between using material.flatShading=true or geometry.computeTangents().

@sunag sunag added this to the r178 milestone Jun 19, 2025
@github-actions
Copy link

github-actions bot commented Jun 19, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 337.54
78.73
337.54
78.73
+0 B
+0 B
WebGPU 556.43
154.15
556.74
154.17
+318 B
+26 B
WebGPU Nodes 555.78
153.99
556.1
154.01
+318 B
+25 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 468.74
113.38
468.74
113.38
+0 B
+0 B
WebGPU 632.24
171.08
632.55
171.18
+317 B
+102 B
WebGPU Nodes 587.24
160.39
587.56
160.5
+317 B
+111 B

@sunag sunag changed the title TSL: Introduce tangentFrame TSL: Introduce tangentViewFrame and bitangentViewFrame Jun 19, 2025
@sunag sunag marked this pull request as ready for review June 20, 2025 18:39
@sunag sunag merged commit cde19cf into mrdoob:dev Jun 21, 2025
12 checks passed
@sunag sunag deleted the dev-fix-tangentframe branch June 21, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant