Skip to content

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented May 7, 2025

Related issue: #31045 (comment)

Description

The new asset for the tone mapping demos exhibits an issue in WebGPURenderer. Turns out, #30837 introduced a minor regression in getBitangent(). The returned varying referred to a wrong value.

@Mugen87 Mugen87 requested a review from sunag May 7, 2025 09:20
@github-actions
Copy link

github-actions bot commented May 7, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.29
78.32
336.29
78.32
+0 B
+0 B
WebGPU 548.2
152.02
548.2
152.02
+0 B
+0 B
WebGPU Nodes 547.55
151.86
547.55
151.86
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 466.23
112.58
466.23
112.58
+0 B
+0 B
WebGPU 622.98
168.71
622.98
168.71
+0 B
+3 B
WebGPU Nodes 577.85
158
577.85
158
+0 B
+1 B

@Mugen87 Mugen87 added this to the r177 milestone May 7, 2025
@sunag
Copy link
Collaborator

sunag commented May 8, 2025

Thank you! I'm working on a better solution for normals to solve the flatShading bug and remove the transformed prefix, this involves some TSL improvements to make the solution simpler.

/cc @WestLangley @mrdoob

@sunag sunag merged commit 4b29a47 into mrdoob:dev May 8, 2025
12 checks passed
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
* TSL: Fix `getBitangent()`.

* E2E: Update screenshot.
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
* TSL: Fix `getBitangent()`.

* E2E: Update screenshot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants