MeshNormalMaterial improvements #10343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ading, morphs, skinning
Collaborator
Author
|
Hmm. I miss threejsworker. Here is a screenshot.
|
Contributor
|
Very nice. :) I think this is great. And all the new features are optional too so that is great. This will allow for effects like SAO and SSAO to produce better results on models who represent their normals using normal or bump maps. I can not wait to try it out. Thank you @WestLangley |
Collaborator
Author
Owner
|
Thanks thanks! |
Owner
Yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #10330
Fixed some bugs. Added support for normal/bump/displacement maps, flat shading, morphs, skinning.
Removed support for clipping ( at least for now ) as the chunk
if-defsare becoming more and more difficult to get right. I am not sure clipping is a big deal for this material, anyway, as it is primarily a diagnostic tool./ping @bhouston