MeshNormalMaterial: support clipping planes #16634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes rendering of screen space effects depending on normals in the presence of a global clipping plane.
Collaborator
|
Thanks! EDIT: Oh wait! I was the one that removed clipping support. #10343. Apparently there were shader chunk redefinition conflicts at the time... I understand why you added the example, but I don't think it is needed now that you have made your point. I think the example can be removed from this PR. |
It was useful for making sure that clipping planes work as intended for normals when initially implementing the fix, but it's not a very natural fit for the example.
Contributor
Author
|
Removed the example changes as asked. I mostly did them to just have some way of verifying that my changes were correct. Ready to merge? |
Collaborator
|
@mrdoob This PR can be merged. |
Owner
|
Thanks! |
WestLangley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes rendering of screen space effects depending on normals in the presence of a global clipping plane.