-
Notifications
You must be signed in to change notification settings - Fork 29
Merge FDC3 2.0 Conformance Feature Branch #981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(fdc3) - Implement open and raiseIntentForContext
Conformance Framework
fix(examples) - Revert back the apps.json file
Improvements for fdc3.open()
- Marked Context nullable in RaiseIntentRequest - Removed unnecessary string interpolation from Fdc3DesktopAgentErrors - Added TargetInstanceUnavailable to Fdc3DesktopAgentErrors - Added TargetAppUnavailable to ThrowHelper and fixed the error message in TargetInstanceUnavailable
Handle context data correctly in Intents Filter by appid on RaiseIntentForContext
.csproj file updates net6.0 => net8.0 Nuget package updates Convert to common Directory.Build.props Fix for unit tests Common TargetFramework for vanilla net8.0 projects Fdc3 packages reset to 2.0.0 Prevent automatic Nuget package update to .net9
Updated the .NET version in the project from 6.0.x to 8.0.x. Modified multiple sections in README.md to reflect this change, including the framework version table, development setup prerequisites, and the path to the locally compiled shell binary. Updated the .NET Runtime link in the prerequisites for the shell to point to the .NET 8.0.12 version instead of 6.0.16.
* fix(close) - Fixing window.close override as injecting scripts in the NavigationStarting event sometimes prevents the execution of the window.close(); fix(examples) - Fixing examples not loading up on fdc3Ready event as it's triggered before the eventhandler being added; fix(unit-tests) - Fixing failing unit tests
…t when calling handler after returning back the context listener object (#911)
Feat/fdc3 2 0 conformance base net8
Updated the `continuous-integration.yml` and `release.yml` files to use .NET version 8.0.x instead of 6.0.x. Adjusted the path for uploading shell binaries to `net8.0-windows`.
Update CI and release configs to .NET 8.0.x
…n example grid app
…ranch * fix(fdc3-unit-tests) - Fixing FDC3 Typescript lib unit test caused by the downgrade * fix(DA.sln-tests) - Fixing Unit/EndToEnd tests * fix(workflow) - Add CI PR run for the conformance branch * fix(tests) - Add nullable for fields * fix(process-explorer) - Add Skip attribute and reasons
eb6bf1e
to
b4c7b00
Compare
lilla28
previously approved these changes
Mar 12, 2025
psmulovics
previously approved these changes
Mar 17, 2025
ZKRobi
previously approved these changes
Mar 19, 2025
…s when rasing intent via the RaiseIntent or RaiseIntentForContext
… to be passed as null; correct extension class namespace
…Directory, removed duplicated publishing of the raised intents for handling with the right intent listener, added duplicated check on channel ids fix/feat(fdc3) - Checking the Interop.Intents.Raises section from AppDirectory, removed duplicated publishing of the raised intents for handling with the right intent listener, added duplicated check on channel ids
fcd53b5
This was left out when upgrading to .net 8.0
…InfoManager as skipped
…l.Interaction.Abstraction
…in AppDirectory and DesktopAgent
psmulovics
approved these changes
May 7, 2025
cf7b036
to
6be77dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the changes that have been implemented so that ComposeUI is an FDC3 2.0 compliant Desktop Agent.
This feature branch also includes the fixes and improvements that have been introduced after the product has earned the compliance badge.