Skip to content

Conversation

lilla28
Copy link
Contributor

@lilla28 lilla28 commented Sep 30, 2024

Fixed:

  • Fixed existing unit tests in our projects
  • Removed added console.logs() for debugging purpose

Changed:

  • Added unit tests in .Net and Typescript sides for fdc3.open call
  • Improvements around caching the contexts -if the opened app's right context listener is not resolved the context received via the fdc3.open call we cache all the contexts until that context is resolved

Question: should we stop the module via module loader if the request fails but the start of the app was succesful? (e.g. context listener is not registered so AppTimeout happens) -> Conformance framework tests are closing the window if the request fails in this case.

@lilla28 lilla28 marked this pull request as ready for review October 2, 2024 11:13
@lilla28 lilla28 requested a review from a team as a code owner October 2, 2024 11:13
@lilla28 lilla28 merged commit 11bec43 into morganstanley:feat/fdc3-2_0-conformance Oct 16, 2024
1 check passed
@lilla28 lilla28 deleted the fdc3-open-improv branch February 6, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants