Skip to content

Conversation

bingenito
Copy link
Member

  • Update to Node.JS 22
  • Update to .NET 8 including hoist of targetframework to Directory.Build.props and out of each csproj. Override remains for net8.0-windows

@Copilot Copilot AI review requested due to automatic review settings May 6, 2025 12:30
@bingenito bingenito requested a review from a team as a code owner May 6, 2025 12:30
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@psmulovics psmulovics requested a review from Copilot May 6, 2025 12:40
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the platform prerequisites and CI/CD configurations to support Node.js 22 and .NET 8. The changes include updating the README prerequisites, modifying GitHub workflow files for release, PR builds, site deployment, and continuous integration.

Reviewed Changes

Copilot reviewed 29 out of 44 changed files in this pull request and generated no comments.

Show a summary per file
File Description
README.md Updated prerequisites to reflect Node.js 22 and .NET 8
.github/workflows/release.yml Changed Node.js and .NET versions for release builds
.github/workflows/pr-build-site.yml Updated Node.js version configuration for PR site builds
.github/workflows/deploy-site.yml Updated Node.js version configuration for deploying the site
.github/workflows/continuous-integration.yml Updated Node.js and .NET versions, and artifact upload path for CI runs
Files not reviewed (15)
  • Directory.Build.props: Language not supported
  • examples/dotnet-diagnostics/DiagnosticsExample/DiagnosticsExample.csproj: Language not supported
  • prototypes/process-explorer/dotnet/src/MorganStanley.ComposeUI.ProcessExplorer.Abstractions/MorganStanley.ComposeUI.ProcessExplorer.Abstractions.csproj: Language not supported
  • prototypes/process-explorer/dotnet/src/MorganStanley.ComposeUI.ProcessExplorer.Client/MorganStanley.ComposeUI.ProcessExplorer.Client.csproj: Language not supported
  • prototypes/process-explorer/dotnet/src/MorganStanley.ComposeUI.ProcessExplorer.Core/MorganStanley.ComposeUI.ProcessExplorer.Core.csproj: Language not supported
  • prototypes/process-explorer/dotnet/src/MorganStanley.ComposeUI.ProcessExplorer.GrpcWebServer/MorganStanley.ComposeUI.ProcessExplorer.GrpcWebServer.csproj: Language not supported
  • prototypes/process-explorer/dotnet/test/MorganStanley.ComposeUI.ProcessExplorer.Client.Tests/MorganStanley.ComposeUI.ProcessExplorer.Client.Tests.csproj: Language not supported
  • prototypes/process-explorer/dotnet/test/MorganStanley.ComposeUI.ProcessExplorer.Core.Tests/MorganStanley.ComposeUI.ProcessExplorer.Core.Tests.csproj: Language not supported
  • prototypes/process-explorer/dotnet/test/MorganStanley.ComposeUI.TestConsoleApp/MorganStanley.ComposeUI.TestConsoleApp.csproj: Language not supported
  • prototypes/process-explorer/dotnet/test/MorganStanley.ComposeUI.TestConsoleApp2/MorganStanley.ComposeUI.TestConsoleApp2.csproj: Language not supported
  • src/fdc3/dotnet/AppDirectory/src/MorganStanley.ComposeUI.AppDirectory/MorganStanley.ComposeUI.AppDirectory.csproj: Language not supported
  • src/fdc3/dotnet/AppDirectory/test/MorganStanley.ComposeUI.AppDirectory.Tests/MorganStanley.ComposeUI.AppDirectory.Tests.csproj: Language not supported
  • src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/MorganStanley.ComposeUI.DesktopAgent.csproj: Language not supported
  • src/fdc3/dotnet/DesktopAgent/test/MorganStanley.ComposeUI.DesktopAgent.Tests/MorganStanley.ComposeUI.DesktopAgent.Tests.csproj: Language not supported
  • src/layout-persistence/dotnet/src/MorganStanley.ComposeUI.LayoutPersistence/MorganStanley.ComposeUI.LayoutPersistence.csproj: Language not supported
Comments suppressed due to low confidence (3)

README.md:39

  • [nitpick] Ensure all related documentation is updated to reflect the change in Node.js prerequisites if additional guidance is required.
+ Node.js 22

.github/workflows/release.yml:81

  • Verify that all associated build and deployment tasks are compatible with .NET 8 to prevent unexpected build issues.
+          dotnet-version: 8.0.x

.github/workflows/continuous-integration.yml:85

  • Confirm that the updated artifact path aligns with the actual output directory for .NET 8 builds to ensure proper artifact collection.
+        path: ${{ github.workspace }}/src/shell/dotnet/Shell/bin/Release/net8.0-windows/

@kruplm
Copy link
Contributor

kruplm commented May 6, 2025

@bingenito we upgraded the tooling as part of the FDC3 2.0 Compliance feature branch. We agreed to do this so that it won't cause discrepancies when we merge the FDC3 2.0 feature branch.

@bingenito bingenito closed this May 6, 2025
@psmulovics
Copy link
Member

So let's merge #981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants