Skip to content

[libffi] Support arm/arm64 #10485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 6, 2020
Merged

[libffi] Support arm/arm64 #10485

merged 5 commits into from
Apr 6, 2020

Conversation

JackBoosY
Copy link
Contributor

Fix arm/arm64 build, pass the correct arm / arm64 parameters to cmake.

Related: #10469.

@derselbst
Copy link
Contributor

Could somebody pls. clarify why CMAKE_SYSTEM_PROCESSOR is used to determine the target? Whenever I try cross-compiling, it's set to AMD64, which is my host processor.

Also please note that VCPKG_TARGET_ARCHITECTURE could be used directly, so there should be no need to introduce a custom ARCH_NAME variable in the CMakeLists.txt.

derselbst
derselbst reviewed Mar 22, 2020
View reviewed changes
@JackBoosY JackBoosY marked this pull request as ready for review March 23, 2020 02:26
@ArashPartow ArashPartow mentioned this pull request Mar 23, 2020
Closed
@JackBoosY
Copy link
Contributor Author

/azp run

This was referenced Mar 26, 2020
Merged
Closed
Merged
@JackBoosY
Copy link
Contributor Author

/azp run

@JackBoosY JackBoosY requested a review from PhoebeHui April 1, 2020 02:29
@JackBoosY
Copy link
Contributor Author

/azp run

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Apr 3, 2020
@dan-shaw dan-shaw merged commit 6283a51 into microsoft:master Apr 6, 2020
@JackBoosY JackBoosY deleted the dev/jack/fix-libffi-arm-build branch April 7, 2020 03:08
@JackBoosY JackBoosY mentioned this pull request Apr 7, 2020
Merged
@derselbst derselbst mentioned this pull request Apr 7, 2020
Merged
derselbst added a commit to FluidSynth/fluidsynth that referenced this pull request Apr 8, 2020
@derselbst
Fix cross-compilation from Win32 to ARM using vcpkg (#630)
85237e4 
For some reason, the configure command must be specified explicitly in the `gentables` build step. Otherwise, the ARM target compiler will be used to build `make_tables` rather than the host compiler. 

Now that microsoft/vcpkg#10485 has been completed, an ARM CI build can be added to AppVeyor. Also, the build status table in the README has been updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

+1 more reviewer

@derselbst derselbst derselbst left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@PhoebeHui PhoebeHui

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JackBoosY @derselbst @PhoebeHui @dan-shaw