Skip to content

[ffmpeg] Install tools #10486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 28, 2020
Merged

[ffmpeg] Install tools #10486

merged 4 commits into from
Mar 28, 2020

Conversation

JackBoosY
Copy link
Contributor

Install tools when selecting feature ffmpeg.

Related: #9619.

@JackBoosY JackBoosY marked this pull request as ready for review March 22, 2020 12:37
@JackBoosY JackBoosY requested a review from PhoebeHui March 22, 2020 12:37
@ArashPartow ArashPartow mentioned this pull request Mar 23, 2020
Closed
PhoebeHui
PhoebeHui approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JackBoosY
Copy link
Contributor Author

/azp run

@JackBoosY
Copy link
Contributor Author

JackBoosY commented Mar 26, 2020 •
edited
Loading

I can't repro aubio:x64-windows-static regression on my machine.
Seems failure on post check dumpbin, I have another PR #10485 that also has this type of regressions.

This was referenced Mar 26, 2020
Merged
Closed
Merged
@JackBoosY
Copy link
Contributor Author

/azp run

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Mar 26, 2020
@cenit
Copy link
Contributor

cenit commented Mar 26, 2020

also related to #10368 which deleted them from bin folder

@dan-shaw dan-shaw merged commit 774f4fe into microsoft:master Mar 28, 2020
@JackBoosY JackBoosY deleted the dev/jack/9619 branch March 30, 2020 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JackBoosY @cenit @PhoebeHui @dan-shaw