[libffi] Check return value of execute_process() #10469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@derselbst, thanks for bringing this up! We considered a fix for libffi:arm64-wiindows port or upstream needed instead. |
|
Hi @derselbst, I've fixed this issue in #10485, please update vcpkg and rebuild libffi. Thanks. |
|
It works now, thanks. But why closing this? This PR only adds additional error checking and should still be merged. Calling |
|
/azp run |
|
@derselbst Sorry, I closed this PR by mistake. |
JackBoosY
suggested changes
Apr 8, 2020
There was a problem hiding this comment.
Please update libffi version info in VCPKG_PATH/ports/libffi/CONTROL.
See documentation.
|
/azp run |
To avoid hiding errors, the return values of the execute_process() commands should be checked and a fatal error should be issued.
|
|
JackBoosY
approved these changes
Apr 9, 2020
JackBoosY
added
info:reviewed
|
LGTM, thanks for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently unable to cross-compile libffi for arm64. The "compile assembly"
execute_process()step silently fails and CMake later complains that the .obj file is not available. To avoid hiding errors, the return values of theexecute_process()commands should be checked and a fatal error should be issued.(Here's the build log, in case smb. is interested: https://ci.appveyor.com/project/derselbst/fluidsynth-g2ouw/builds/31479626/job/hm9u92nejl7083dx#L596)