Add JSValue constructor for std::optional<T> #6873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickGerleman
approved these changes
Jan 15, 2021
asklar
reviewed
Jan 15, 2021
| inline JSValue::JSValue(double value) noexcept : m_type{JSValueType::Double}, m_double{value} {} | ||
| template <class T> | ||
| inline JSValue::JSValue(std::optional<T> &&value) noexcept | ||
| : JSValue(value.has_value() ? JSValue(std::move(value).value()) : JSValue()) {} |
Member
There was a problem hiding this comment.
If I understand this correctly this is equating an empty value, with null; shouldn't it be equating it with undefined instead? are null and undefined the same as far as JSValue knows? and if so is that right?
Member
Author
There was a problem hiding this comment.
The JSValue is designed to represent a JSON value with some design features from folly:dynamic such as having Int64 and Double types instead of a single Number type. It only recognizes Null. It does not support the undefined type.
vmoroz
added a commit
that referenced
this pull request
Jan 15, 2021
* Fix unused parameter warning in AbiCallInvoker (#6860) * Move CallInvoker.h to TurboModule filter folder (#6861) * Simplify Microsoft.ReactNative.IntegrationTests (#6868) * Update clang-format version to 1.5.0 (#6870) * Add JSValue constructor for std::optional<T> (#6873) * Updated doc comments in IReactNotificationService.idl (#6875) * Fix ReactNotificationService for notifications between app and modules (#6877)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we are adding
JSValueconstructors forstd::optional<T>andstd::nullopt_t.They are convenient to use with
ReactPropertyBag,ReactNotificationService, and other classes that returnstd::optional<T>which we then want to assign toJSValue.The
std::nullopt_tor emptystd::optional<T>will result in creation ofJSValue::Null.For non-empty
std::optional<T>the result will depend on the typeT.Microsoft Reviewers: Open in CodeFlow