Skip to content

Conversation

@vmoroz
Copy link
Member

@vmoroz vmoroz commented Jan 13, 2021

This is a "cosmetic" change in Microsoft.ReactNative.Cxx project.
We fix the location of the CallInvoker.h in the visual tree in the Visual Studio - no functional changes.
It is moved to the "TurboModule" folder along with other TurboModule related files.
Note, that the CallInvoker.h is referenced from the RN code. It is not part of RNW code.

Microsoft Reviewers: Open in CodeFlow

@vmoroz vmoroz requested a review from a team January 13, 2021 17:49
@vmoroz vmoroz requested a review from a team as a code owner January 13, 2021 17:49
@vmoroz vmoroz added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Jan 13, 2021
@ghost
Copy link

ghost commented Jan 13, 2021

Hello @vmoroz!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@NikoAri NikoAri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ghost ghost merged commit b3694b7 into microsoft:master Jan 14, 2021
vmoroz added a commit that referenced this pull request Jan 15, 2021
* Fix unused parameter warning in AbiCallInvoker (#6860)

* Move CallInvoker.h to TurboModule filter folder (#6861)

* Simplify Microsoft.ReactNative.IntegrationTests (#6868)

* Update clang-format version to 1.5.0 (#6870)

* Add JSValue constructor for std::optional<T> (#6873)

* Updated doc comments in IReactNotificationService.idl (#6875)

* Fix ReactNotificationService for notifications between app and modules (#6877)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants