Update clang-format version to 1.5.0 #6870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickGerleman
approved these changes
Jan 14, 2021
Contributor
NickGerleman
left a comment
NickGerleman
left a comment
There was a problem hiding this comment.
Change looks good to me, but please remove the dependency from the root package.json before merging.
dannyvv
approved these changes
Jan 14, 2021
Member
dannyvv
left a comment
dannyvv
left a comment
There was a problem hiding this comment.
Looks like most of the changes the new version brought in are better,
Still clang format remains to have some baffling formatting behavior to me :)
vmoroz
added a commit
that referenced
this pull request
Jan 15, 2021
* Fix unused parameter warning in AbiCallInvoker (#6860) * Move CallInvoker.h to TurboModule filter folder (#6861) * Simplify Microsoft.ReactNative.IntegrationTests (#6868) * Update clang-format version to 1.5.0 (#6870) * Add JSValue constructor for std::optional<T> (#6873) * Updated doc comments in IReactNotificationService.idl (#6875) * Fix ReactNotificationService for notifications between app and modules (#6877)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am getting clang-format crashes when editing JSValueTests.cpp.
Our clang-format version is very old.
I have updated it to 1.5.0 and I do not see crashes anymore.
It also produces much better formatting results, but the changes resulted in a lot of files changed due to reformatting.
Note: No changes are done to files except for the automated changes by calling
yarn format.The clang-format is added to the root
package.jsonto be automatically updated in future.Microsoft Reviewers: Open in CodeFlow