Update Node to v16 #11500
Merged
Update Node to v16 #11500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
doesn't the setup script need to be updated too? |
Contributor
Author
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
jonthysell
reviewed
Apr 20, 2023
| @{ | ||
| Id=[CheckId]::Node; | ||
| Name = 'Node.js (LTS, >= 14.0)'; | ||
| Name = 'Node.js (LTS, >= 16.0)'; |
Contributor
There was a problem hiding this comment.
You also need to update the CheckNode function
jonthysell
reviewed
Apr 20, 2023
| - name: versions | ||
| type: object | ||
| default: [14, 16] | ||
| default: [16] |
Contributor
There was a problem hiding this comment.
We might want to add node 18 in here since it's been LTS for a long time now
Member
There was a problem hiding this comment.
Node.js is about to release version 20.
Contributor
There was a problem hiding this comment.
We should definitely add 20 when it's out and see if there's any problems as new devs will probably install 20 by default
Contributor
Author
There was a problem hiding this comment.
Addition of 18 threw errors in the testing. Looks like there's an API that is no longer available on 18 that we use. I'll file an issue to track addressing that.
Contributor
There was a problem hiding this comment.
You know, that sounds familliar - something that changed at like 18.5 or something.
jonthysell
approved these changes
Apr 20, 2023
Contributor
jonthysell
left a comment
jonthysell
left a comment
There was a problem hiding this comment.
Once you at least update the dep script it should be good to go.
vmoroz
approved these changes
Apr 20, 2023
jonthysell
approved these changes
Apr 20, 2023
jonthysell
approved these changes
Apr 21, 2023
| - name: versions | ||
| type: object | ||
| default: [14, 16] | ||
| default: [16] |
Contributor
There was a problem hiding this comment.
You know, that sounds familliar - something that changed at like 18.5 or something.
|
Bump babel config as well? |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Apr 26, 2023
Summary: **NOTE**: This is a **BREAKING** change. TLDR; Enforce minimum Node.js v16 in all RN packages. This diff **Updates Node.js to v16** across all RN packages. #### Context: - For RN development and new project created; bump to node 16 was in #36217 - Recently `react-native-windows` also; updated node to v16, microsoft/react-native-windows#11500 #### Changes: - [BREAKING] Update Node.js to v16 across all RN packages under 'packages/' dir ## Changelog: [GENERAL][BREAKING] - Update Node.js to v16 in all RN packages Pull Request resolved: #37073 Test Plan: - `yarn lint && yarn flow && yarn test-ci` --> _should be green_ Reviewed By: cipolleschi Differential Revision: D45306108 Pulled By: jacdebug fbshipit-source-id: e3ba7d0151b86a6a0a3d63fb29c2bd887e1ac1e7
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: **NOTE**: This is a **BREAKING** change. TLDR; Enforce minimum Node.js v16 in all RN packages. This diff **Updates Node.js to v16** across all RN packages. #### Context: - For RN development and new project created; bump to node 16 was in facebook#36217 - Recently `react-native-windows` also; updated node to v16, microsoft/react-native-windows#11500 #### Changes: - [BREAKING] Update Node.js to v16 across all RN packages under 'packages/' dir ## Changelog: [GENERAL][BREAKING] - Update Node.js to v16 in all RN packages Pull Request resolved: facebook#37073 Test Plan: - `yarn lint && yarn flow && yarn test-ci` --> _should be green_ Reviewed By: cipolleschi Differential Revision: D45306108 Pulled By: jacdebug fbshipit-source-id: e3ba7d0151b86a6a0a3d63fb29c2bd887e1ac1e7
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: **NOTE**: This is a **BREAKING** change. TLDR; Enforce minimum Node.js v16 in all RN packages. This diff **Updates Node.js to v16** across all RN packages. #### Context: - For RN development and new project created; bump to node 16 was in facebook#36217 - Recently `react-native-windows` also; updated node to v16, microsoft/react-native-windows#11500 #### Changes: - [BREAKING] Update Node.js to v16 across all RN packages under 'packages/' dir ## Changelog: [GENERAL][BREAKING] - Update Node.js to v16 in all RN packages Pull Request resolved: facebook#37073 Test Plan: - `yarn lint && yarn flow && yarn test-ci` --> _should be green_ Reviewed By: cipolleschi Differential Revision: D45306108 Pulled By: jacdebug fbshipit-source-id: e3ba7d0151b86a6a0a3d63fb29c2bd887e1ac1e7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Why
Upgrade Node to v16. Upstream is making the same update for v72.
Resolves #11451
Microsoft Reviewers: Open in CodeFlow