Replace negative lookbehind with a more supported regular expression #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o firefox incompatibility
Member
|
Whoo! Thanks for this. I'm a Regex noob. |
Member
|
This PR has been released in v3.0.6. Thank you again for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change introduced in #832 used a regular expression not supported in all browser. This regular expression has been removed and replaced with a functional equivalent.
The replacement regex looks for an unescaped or already escaped question mark and replaces it with an escaped one. While it isn't as pretty since we still replace a properly escaped query, it was the most straightforward solution that didn't require additional conditional logic.