provide fix for bug related to parsing GET parameters #832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Whoa, thanks for all the hard work here! Excellent PR. Merging now. |
Member
|
@kyle-mccarthy Looks like this fix isn't working in Firefox. |
Contributor
Author
|
@desandro Sorry about that, I did not realize that Firefox didn't support negative lookbehinds. I opened another PR fixing the problem (and tested it in FF this time :)). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #831. I've updated the code and provided a test case.
This problem is caused when the
pathoption is a GET parameter. With the current version, you can make it work if you escape the?; however, I didn't see documentation detailing this. In this PR I escape the?if it hasn't already been properly escaped when setting the option.Basically, this currently doesn't work
blog?page={{#}}but doing thisblog\\?page={{#}}will work. Prior to changing out{{#}}with the regexp to match the page number, I convertblog?page={{#}}toblog\\?page={{#}}if the user hasn't already done so.