Skip to content

Replace negative lookbehind with a more supported regular expression #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
desandro merged 5 commits into from
Oct 12, 2018
Merged

Replace negative lookbehind with a more supported regular expression #837

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b0521cb
provide fix for bug related to parsing GET parameters
kyle-mccarthy Oct 3, 2018
c15a16f
expand to test for a path that has already escaped the query string
kyle-mccarthy Oct 3, 2018
33d0ee7
remove negative lookbehind and replaced with alternative regexp due t…
kyle-mccarthy Oct 12, 2018
fd6289d
merge metafizzy master
kyle-mccarthy Oct 12, 2018
c3111b6
follow code style
kyle-mccarthy Oct 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ proto.updateGetPathTemplate = function( optPath ) {
// convert path option into regex to look for pattern in location
// escape query (?) in url, allows for parsing GET parameters
var regexString = optPath
.replace( /(?<!\\)\?/, '\\?' )
.replace( /(\\\?|\?)/, '\\?' )
.replace( '{{#}}', '(\\d\\d?\\d?)' );
var templateRe = new RegExp( regexString );
var match = location.href.match( templateRe );
Expand Down