Skip to content

✅ Update all tests to Jest #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Jul 27, 2020
Merged

✅ Update all tests to Jest #46

merged 28 commits into from
Jul 27, 2020

Conversation

wm4tos
Copy link
Contributor

@wm4tos wm4tos commented Jul 24, 2020

Description of the Change

Ends work of @ohager on #43

This changes contains jest-ts, and parse.test.js and runner.test.js are totally converted to ts.
This branch resolves #41

ohager and others added 22 commits July 15, 2020 19:08
feat: Allowing empty fields for mutations
f14c422
chore: lint fix
1e3eb10
fix: corected test 38
0c8c376
feat: Added jest for TS and converted parser tests to jest
b6a5050
chore: apply PR suggestions
779bfe8
@khaosdoctor
Apply suggestions from code review
fed6dd3
@khaosdoctor
🎨 Add default value for param
eeaa5aa
@wm4tos
Merge branch 'master' of https://github.com/wricke/gotql into feat/jest
064101e
@wm4tos
add "endpoint" and "options" properties to "GotQL.Response" type
5078b3b
@wm4tos
define type of "handleResponse" return
d8dc85f
@wm4tos
import from ts file instead transpiled files
fbbbd74
@wm4tos
rename file
1091485
@wm4tos
rewrite context of test
5e1af11
@wm4tos
reimplement 'Should successfully perform a simple query on DNS endpoi…
5aed2de 
…nt' test
@wm4tos
reimplement 'Should successfully perform a simple query on IP endpoin…
d04d482 
…t' test
@wm4tos
reimplement 'Should successfully handle a simple query errors on DNS …
11630c6 
…endpoint' test
@wm4tos
reimplement 'Should successfully handle a simple query errors on IP e…
6024abb 
…ndpoint' test
@wm4tos
reimplement 'Should successfully handle a simple query errors with cu…
bd92597 
…stom codes' test
@wm4tos
reimplement 'Should successfully handle a simple query with custom he…
9c9fb08 
…aders' test
@wm4tos
reimplement 'Should successfully handle a simple query with variables…
15b58e2 
…' test
@wm4tos
remove 'Should successfully handle error when type is not passed' bec…
fd62891 
…ause he verifies the type of a variable who now is a enum
@wm4tos
Merge remote-tracking branch 'fork/main' into feat/jest
82e109e
@ohager ohager mentioned this pull request Jul 24, 2020
Closed
ohager
ohager approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@ohager ohager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wricke Thanks for continuation. LGTM

@khaosdoctor
Copy link
Owner

Thanks for the continuation! Awesome work :)

I'm still reviewing the code. But can you please change the file names to *.test.ts? This is the default pattern I've been using in this repo, this way GitHub can also display the diffs properly. Otherwise it creates two different huge diffs like you deleted one file and create another

@wm4tos
Copy link
Contributor Author

wm4tos commented Jul 24, 2020

Name changed @khaosdoctor.

tiago154
tiago154 reviewed Jul 24, 2020
View reviewed changes
khaosdoctor
khaosdoctor requested changes Jul 25, 2020
View reviewed changes
@khaosdoctor
Copy link
Owner

khaosdoctor commented Jul 25, 2020 •
edited
Loading

I added another file, the .editorconfig because I noticed your changes will break the code style. Can you pull the changes from main?

@wm4tos wm4tos requested a review from khaosdoctor July 25, 2020 04:34
@tiago154 tiago154 mentioned this pull request Jul 25, 2020
Merged
khaosdoctor
khaosdoctor reviewed Jul 27, 2020
View reviewed changes
@khaosdoctor
Copy link
Owner

Thanks for the update, I'll check it along with #47 today!

@khaosdoctor khaosdoctor changed the title Feat/jest ✅ Update all tests to Jest Jul 27, 2020
@khaosdoctor khaosdoctor merged commit 049eced into khaosdoctor:main Jul 27, 2020
@wm4tos wm4tos deleted the feat/jest branch July 27, 2020 18:32
@khaosdoctor khaosdoctor mentioned this pull request Jul 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaosdoctor khaosdoctor khaosdoctor requested changes

+2 more reviewers

@ohager ohager ohager approved these changes

@tiago154 tiago154 tiago154 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] Change the default code runner to Jest
4 participants
@wm4tos @khaosdoctor @ohager @tiago154