Feature Tagged Template 'literal' #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaosdoctor
requested changes
Jul 27, 2020
src/helpers/literal.ts
Outdated
Comment on lines
12
to
15
| export const literal = (literalValue: TemplateStringsArray): LiteralObject => { | ||
| if (!literalValue || !literalValue[0]) throw new Error('literalValue cannot be null or empty') | ||
| return { value: literalValue[0], escape: false } | ||
| } |
There was a problem hiding this comment.
Can you please change this definition to a function definition to follow the code style?
Suggested change
| export const literal = (literalValue: TemplateStringsArray): LiteralObject => { | |
| if (!literalValue || !literalValue[0]) throw new Error('literalValue cannot be null or empty') | |
| return { value: literalValue[0], escape: false } | |
| } | |
| function literal (literalValue: TemplateStringsArray): LiteralObject { | |
| if (!literalValue || !literalValue[0]) throw new Error('Value for the literal argument cannot be null or empty') | |
| return { value: literalValue[0], escape: false } | |
| } | |
| export literal |
There was a problem hiding this comment.
Actually, I think there are empty arguments (as of #39), so probably, we would want something like this:
Suggested change
| export const literal = (literalValue: TemplateStringsArray): LiteralObject => { | |
| if (!literalValue || !literalValue[0]) throw new Error('literalValue cannot be null or empty') | |
| return { value: literalValue[0], escape: false } | |
| } | |
| function literal (literalValue: TemplateStringsArray): LiteralObject { | |
| return { value: literalValue[0] || "", escape: false } | |
| } | |
| export literal |
tests/helpers/literal.test.ts
Outdated
Comment on lines
21
to
28
| it('should return an error when the argument is empty', () => { | ||
| expect(() => literal``).toThrowError('literalValue cannot be null or empty') | ||
| }) | ||
|
|
||
| it('should return an error when the argument is null', () => { | ||
| const nullValue = null as unknown as TemplateStringsArray | ||
| expect(() => literal(nullValue)).toThrowError('literalValue cannot be null or empty') | ||
| }) |
There was a problem hiding this comment.
Then you could change these tests to assert the value is ""
There was a problem hiding this comment.
Changed the tests. Check if you agree or need any more cases.
|
@tiago154 congrats on the test runs, they're 100%
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Issue -> #40
With this modification, a function named 'literal' was added, which is nothing more than an abbreviation for the
Where we can use it as follows.
The test of this function was written in typescript, aiming to close this PR here #46
Benefits
Shortens the object that needs to be used literally
Applicable Issues
#40