Skip to content

Feat/jest #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Feat/jest #43

wants to merge 10 commits into from

Conversation

ohager
Copy link
Contributor

@ohager ohager commented Jul 15, 2020

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Helping you out with Jest set up for TS and already converted parser tests to jest as you mentioned in #41

Please merge #42 before

This PR solves issue #41 only partially, but I think it's a good starting point ;)

Feel free to neglect it

Note: that I want to merge into your dev branch, as it is an incomplete feature (missing runner.test.js)

@khaosdoctor
Copy link
Owner

Hello! Thanks for the PR!

We'll probably have issues because I think this branch is not up to date with the master branch. I'll merge both. If you can, please merge master into your dev and commit the results

@khaosdoctor
Copy link
Owner

I'll close this PR so you can update it in your fork, please open another one when you update your dev branch :)

@ohager
Copy link
Contributor Author

ohager commented Jul 24, 2020

@khaosdoctor damn, haven't seen your comments. Sorry, for late response. But seems that @wricke resolved it already in #46.

@khaosdoctor
Copy link
Owner

No problem! If you want to help you can both work on that content! I’m really glad you all helped! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants