-
-
Notifications
You must be signed in to change notification settings - Fork 372
test: Ensure test is server running #6300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ensure that the test server is running with a retry mechanism to avoid flakiness in CI.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6300 +/- ##
=============================================
+ Coverage 86.742% 86.785% +0.042%
=============================================
Files 438 438
Lines 37323 37323
Branches 17433 17437 +4
=============================================
+ Hits 32375 32391 +16
+ Misses 4902 4887 -15
+ Partials 46 45 -1 see 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Back to draft cause tests are failing |
Ensure that the test server is running with a retry mechanism to avoid flakiness in CI.
* test: Ensure test is server running (#6300) Ensure that the test server is running with a retry mechanism to avoid flakiness in CI. * ci: Add v8.x branch to workflows (#6321) * chore: Explain v8 branch (#6323) Add decision log entry for v8 branch and explain how to release from it. * ci(v8): Bump Xcode from 26.0 to 26.0.1 (#6394) * docs: Add note to README with reference to v9 on main branch (#6402) * fix: Wrong Frame Delay when becoming active (#6393) The SDK reported false frame delay statistics when it moved from the background to the foreground, which also led to falsely reported app hangs. Fixes GH-6345 * fix(session-replay): Add detection for potential PII leaks disabling session replay (#6389) * release: 8.57.0 * chore: Bump simulators to 26.1 (#6578) * fix: Fix crash when last replay info is missing some keys (#6577) * fix: Fix crash when last replay info is missing keys * Update changelog * fix: Disable SessionSentryReplayIntegration if the environment is unsafe (#6573) * fix: Disable SessionSentryReplayIntegration if the environment is unsafe * Simplify shouldEnableSessionReplay * Rename test * Add log message * Update changelog * Safely unwrap SentryOptions * fix: Fix UITouch background thread access in SentryTouchTracker (#6584) * release: 8.57.1 * Fix merge issues * Fix another merge issue * More merge conflicts * Add SentryThreadInspector again * Fix tests on iOS 26 * Add `enableSessionReplayInUnreliableEnvironment` --------- Co-authored-by: Philipp Hofmann <[email protected]> Co-authored-by: Philip Niedertscheider <[email protected]> Co-authored-by: getsentry-bot <[email protected]> Co-authored-by: getsentry-bot <[email protected]>
Ensure that the test server is running with a retry mechanism to avoid flakiness in CI.
#skip-changelog
Note
Adds a retry-based test server readiness check and stabilizes network integration tests with task cancellation, expectation tweaks, longer timeouts, and stricter assertions.
ensureTestServerIsRunning()to pollhttp://localhost:8080/with retries before tests run.defer { dataTask.cancel() }in requests and setexpect.assertForOverFulfill = falseto avoid double-fulfillment.5to10seconds.expect.expectedFulfillmentCount = 2and fulfill in completion handler.XCTUnwrapforcontext.responseandstatus_codeand compare extractedstatusCodeto400.Written by Cursor Bugbot for commit a7604f8. This will update automatically on new commits. Configure here.
Closes #6301