Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Oct 28, 2025

Fixes crash when last replay info is missing some keys

Closes #6580

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.083%. Comparing base (41834f1) to head (2aa17a2).
⚠️ Report is 1 commits behind head on v8.x.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Sources/Sentry/SentrySessionReplayIntegration.m 62.500% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              v8.x     #6577       +/-   ##
=============================================
+ Coverage   85.676%   86.083%   +0.406%     
=============================================
  Files          441       441               
  Lines        27417     27442       +25     
  Branches     10357     11916     +1559     
=============================================
+ Hits         23490     23623      +133     
+ Misses        3886      3773      -113     
- Partials        41        46        +5     
Files with missing lines Coverage Δ
Sources/Sentry/SentrySessionReplayIntegration.m 86.067% <62.500%> (-1.000%) ⬇️

... and 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41834f1...2aa17a2. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1234.55 ms 1262.58 ms 28.03 ms
Size 23.75 KiB 992.02 KiB 968.28 KiB

Baseline results on branch: v8.x

Startup times

Revision Plain With Sentry Diff
f76f6bf 1207.70 ms 1233.27 ms 25.57 ms
c11a8e0 1203.00 ms 1223.23 ms 20.23 ms
ab82dac 1249.73 ms 1272.69 ms 22.96 ms
41834f1 1235.15 ms 1256.31 ms 21.17 ms
a7a0a2b 1218.61 ms 1248.69 ms 30.08 ms
ab82dac 1213.12 ms 1240.92 ms 27.80 ms
b66be9b 1218.22 ms 1244.19 ms 25.96 ms
c6afcc7 1224.31 ms 1256.22 ms 31.92 ms
5e3fb04 1239.84 ms 1267.39 ms 27.55 ms
3af1ae9 1225.60 ms 1252.65 ms 27.05 ms

App size

Revision Plain With Sentry Diff
f76f6bf 23.74 KiB 981.30 KiB 957.56 KiB
c11a8e0 23.75 KiB 991.86 KiB 968.12 KiB
ab82dac 23.75 KiB 991.85 KiB 968.10 KiB
41834f1 23.75 KiB 991.88 KiB 968.13 KiB
a7a0a2b 23.75 KiB 996.04 KiB 972.29 KiB
ab82dac 23.75 KiB 991.86 KiB 968.11 KiB
b66be9b 23.75 KiB 996.03 KiB 972.28 KiB
c6afcc7 23.75 KiB 996.03 KiB 972.28 KiB
5e3fb04 23.74 KiB 981.30 KiB 957.56 KiB
3af1ae9 23.74 KiB 981.29 KiB 957.55 KiB

Previous results on branch: itay/fix_replay_crash

Startup times

Revision Plain With Sentry Diff
478c2a4 1233.88 ms 1261.29 ms 27.41 ms

App size

Revision Plain With Sentry Diff
478c2a4 23.75 KiB 992.03 KiB 968.28 KiB

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@itaybre itaybre merged commit e537c90 into v8.x Oct 29, 2025
206 of 218 checks passed
@itaybre itaybre deleted the itay/fix_replay_crash branch October 29, 2025 12:43
itaybre added a commit that referenced this pull request Oct 30, 2025
* test: Ensure test is server running (#6300)

Ensure that the test server is running with a retry mechanism to avoid
flakiness in CI.

* ci: Add v8.x branch to workflows (#6321)

* chore: Explain v8 branch (#6323)

Add decision log entry for v8 branch and explain how to release from it.

* ci(v8): Bump Xcode from 26.0 to 26.0.1 (#6394)

* docs: Add note to README with reference to v9 on main branch (#6402)

* fix: Wrong Frame Delay when becoming active (#6393)

The SDK reported false frame delay statistics when it moved from the
background to the foreground, which also led to falsely reported app
hangs.

Fixes GH-6345

* fix(session-replay): Add detection for potential PII leaks disabling session replay (#6389)

* release: 8.57.0

* chore: Bump simulators to 26.1 (#6578)

* fix: Fix crash when last replay info is missing some keys (#6577)

* fix: Fix crash when last replay info is missing keys

* Update changelog

* fix: Disable SessionSentryReplayIntegration if the environment is unsafe (#6573)

* fix: Disable SessionSentryReplayIntegration if the environment is unsafe

* Simplify shouldEnableSessionReplay

* Rename test

* Add log message

* Update changelog

* Safely unwrap SentryOptions

* fix: Fix UITouch background thread access in SentryTouchTracker (#6584)

* release: 8.57.1

* Fix merge issues

* Fix another merge issue

* More merge conflicts

* Add SentryThreadInspector again

* Fix tests on iOS 26

* Add `enableSessionReplayInUnreliableEnvironment`

---------

Co-authored-by: Philipp Hofmann <[email protected]>
Co-authored-by: Philip Niedertscheider <[email protected]>
Co-authored-by: getsentry-bot <[email protected]>
Co-authored-by: getsentry-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants