Skip to content

[Related Dashboards] fix href in the dashboard locator #228718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 21, 2025
Merged

[Related Dashboards] fix href in the dashboard locator #228718

merged 3 commits into from
Jul 21, 2025

Conversation

mgiota
Copy link
Contributor

@mgiota mgiota commented Jul 21, 2025 •
edited by kibanamachine
Loading

Summary

Fixes #228619

This PR fixes the issue with right click and opening in a new tab

@mgiota mgiota requested a review from a team as a code owner July 21, 2025 07:34
@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Jul 21, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@mgiota mgiota self-assigned this Jul 21, 2025
@github-actions github-actions bot added the author:obs-ux-management PRs authored by the obs ux management team label Jul 21, 2025
@mgiota mgiota mentioned this pull request Jul 21, 2025
Closed
@mgiota mgiota added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.2.0 labels Jul 21, 2025
@mgiota mgiota changed the title use href instead of onClick for dashboard locator fix href in the dashboard locator in related dashboards Jul 21, 2025
@mgiota mgiota changed the title fix href in the dashboard locator in related dashboards [Related Dashboards] fix href in the dashboard locator Jul 21, 2025
shahzad31
shahzad31 reviewed Jul 21, 2025
View reviewed changes
...ns/observability/public/pages/alert_details/components/related_dashboards/dashboard_tile.tsx Outdated
Comment on lines 52 to 56
<a
href="#"
href={dashboardLocator?.getRedirectUrl({
dashboardId: dashboard.id,
})}
target="_blank"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why aren't we using EuiLink?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used EuiLink in this commit

cesco-f
cesco-f approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@cesco-f cesco-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgiota mgiota enabled auto-merge (squash) July 21, 2025 09:07
@mgiota mgiota merged commit 12683c0 into elastic:main Jul 21, 2025
19 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16414380708

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 21, 2025
@mgiota
[Related Dashboards] fix href in the dashboard locator (elastic#228718)
41f6c3d 
## Summary

Fixes elastic#228619

This PR fixes the issue with right click and opening in a new tab

(cherry picked from commit 12683c0)
@kibanamachine kibanamachine mentioned this pull request Jul 21, 2025
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 21, 2025
@mgiota
[Related Dashboards] fix href in the dashboard locator (elastic#228718)
0a657ab 
## Summary

Fixes elastic#228619

This PR fixes the issue with right click and opening in a new tab

(cherry picked from commit 12683c0)
@kibanamachine kibanamachine mentioned this pull request Jul 21, 2025
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.19
✅ 9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 21, 2025
@kibanamachine @mgiota
[9.1] [Related Dashboards] fix href in the dashboard locator (#228718) (
590de84 
#228745)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Related Dashboards] fix href in the dashboard locator
(#228718)](#228718)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Panagiota
Mitsopoulou","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-07-21T10:20:11Z","message":"[Related
Dashboards] fix href in the dashboard locator (#228718)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/228619\n\nThis
PR fixes the issue with right click and opening in a new
tab","sha":"12683c04dc1560152f32328dfece363a07a44806","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management","v9.2.0"],"title":"[Related
Dashboards] fix href in the dashboard
locator","number":228718,"url":"https://github.com/elastic/kibana/pull/228718","mergeCommit":{"message":"[Related
Dashboards] fix href in the dashboard locator (#228718)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/228619\n\nThis
PR fixes the issue with right click and opening in a new
tab","sha":"12683c04dc1560152f32328dfece363a07a44806"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/228718","number":228718,"mergeCommit":{"message":"[Related
Dashboards] fix href in the dashboard locator (#228718)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/228619\n\nThis
PR fixes the issue with right click and opening in a new
tab","sha":"12683c04dc1560152f32328dfece363a07a44806"}}]}] BACKPORT-->

Co-authored-by: Panagiota Mitsopoulou <[email protected]>
dominiqueclarke
dominiqueclarke reviewed Jul 21, 2025
View reviewed changes
...ns/observability/public/pages/alert_details/components/related_dashboards/dashboard_tile.tsx
<EuiLink
data-test-subj="o11yDashboardTileLink"
href={dashboardLocator?.getRedirectUrl({
dashboardId: dashboard.id,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also pass the time range for the alert here? The dashboard locator supports adding a time range.

@kibanamachine kibanamachine mentioned this pull request Jul 22, 2025
Merged
10 tasks
Bluefinger pushed a commit to Bluefinger/kibana that referenced this pull request Jul 22, 2025
@mgiota @Bluefinger
[Related Dashboards] fix href in the dashboard locator (elastic#228718)
b2d45db 
## Summary

Fixes elastic#228619

This PR fixes the issue with right click and opening in a new tab
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 23, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @mgiota

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @mgiota

kibanamachine added a commit that referenced this pull request Jul 24, 2025
@kibanamachine @mgiota @elasticmachine
[8.19] [Related Dashboards] fix href in the dashboard locator (#228718)…
301dc08 
… (#228744)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Related Dashboards] fix href in the dashboard locator
(#228718)](#228718)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Panagiota
Mitsopoulou","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-07-21T10:20:11Z","message":"[Related
Dashboards] fix href in the dashboard locator (#228718)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/228619\n\nThis
PR fixes the issue with right click and opening in a new
tab","sha":"12683c04dc1560152f32328dfece363a07a44806","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management","v9.2.0"],"title":"[Related
Dashboards] fix href in the dashboard
locator","number":228718,"url":"https://github.com/elastic/kibana/pull/228718","mergeCommit":{"message":"[Related
Dashboards] fix href in the dashboard locator (#228718)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/228619\n\nThis
PR fixes the issue with right click and opening in a new
tab","sha":"12683c04dc1560152f32328dfece363a07a44806"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/228718","number":228718,"mergeCommit":{"message":"[Related
Dashboards] fix href in the dashboard locator (#228718)\n\n##
Summary\n\nFixes https://github.com/elastic/kibana/issues/228619\n\nThis
PR fixes the issue with right click and opening in a new
tab","sha":"12683c04dc1560152f32328dfece363a07a44806"}}]}] BACKPORT-->

Co-authored-by: Panagiota Mitsopoulou <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 24, 2025
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
@mgiota @kertal
[Related Dashboards] fix href in the dashboard locator (elastic#228718)
7908288 
## Summary

Fixes elastic#228619

This PR fixes the issue with right click and opening in a new tab
crespocarlos pushed a commit to crespocarlos/kibana that referenced this pull request Jul 25, 2025
@mgiota @crespocarlos
[Related Dashboards] fix href in the dashboard locator (elastic#228718)
cbfee17 
## Summary

Fixes elastic#228619

This PR fixes the issue with right click and opening in a new tab
@mistic mistic added v8.19.1 and removed v8.19.0 labels Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 left review comments

@dominiqueclarke dominiqueclarke dominiqueclarke left review comments

@cesco-f cesco-f cesco-f approved these changes

Assignees

@mgiota mgiota

Labels
author:obs-ux-management PRs authored by the obs ux management team backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.19.1 v9.1.0 v9.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Suggested Dashboards][Linked Dashboards] Links should include correct hrefs
7 participants
@mgiota @elasticmachine @kibanamachine @shahzad31 @dominiqueclarke @cesco-f @mistic