use href instead of onClick for the dashboard locator #221367
Conversation
github-actions
bot
added
the
author:obs-ux-management
mgiota
added
Team:obs-ux-management
mgiota
added
backport:version
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
| const dashboardLocator = urlService.locators.get<DashboardLocatorParams>(DASHBOARD_APP_LOCATOR); | ||
|
|
||
| useEffect(() => { | ||
| setTimeRange(getPaddedAlertTimeRange(alertStart!, alertEnd)); |
There was a problem hiding this comment.
For some reason, it doesn't seem like the alert end date is working properly for recovered alerts. Whenever I navigate to the url, it just sets the end time as the absolute version of "now". Can you look into this further?
|
@elasticmachine merge upstream |
💔 Build Failed
Failed CI StepsHistory
cc @mgiota |
|
@elasticmachine merge upstream |
|
Hey @mgiota -- @andrewvc had created #228619 and added it to our upcoming iteration, but I just came across this in-progress PR, so I've closed Andrew's issue as a duplicate of the one this PR is closing. I see this PR hasn't had updates since May, I don't remember if we've talked about this at all. Can you remind me what's the status is here? Are we blocked on this? |
|
@jasonrhodes I am closing this one, since main changed and it is easier to fix in a new PR. I just opened a new one that fixes the issue @andrewvc created |
Fixes #221767
Follow up PR to address a few comments on this PR regarding the dashboard locator.
cc @dominiqueclarke