Skip to content

[Related Dashboards] fix href in the dashboard locator #228718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2025
Merged

[Related Dashboards] fix href in the dashboard locator #228718

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02f59dd
use href instead of onClick for dashboard locator
mgiota Jul 21, 2025
7649e55
add back onClick handler, it fixes right click as well
mgiota Jul 21, 2025
1d99fa4
use EuiLink instead
mgiota Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 10 additions & 18 deletions ...observability/public/pages/alert_details/components/related_dashboards/dashboard_tile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
EuiFlexItem,
EuiHorizontalRule,
EuiButtonEmpty,
EuiLink,
} from '@elastic/eui';
import { useKibana } from '../../../../utils/kibana_react';
export interface DashboardMetadata {
Expand Down Expand Up @@ -48,24 +49,15 @@ export function DashboardTile({
<>
<EuiFlexGroup gutterSize="xs" responsive={false} key={dashboard.id}>
<EuiFlexItem key={dashboard.id}>
<EuiText size="s">
<a
href="#"
onClick={async (e) => {
e.preventDefault();
if (dashboardLocator) {
const url = await dashboardLocator.getUrl({
dashboardId: dashboard.id,
});
window.open(url, '_blank');
} else {
console.error('Dashboard locator is not available');
}
}}
>
{dashboard.title}
</a>
</EuiText>
<EuiLink
data-test-subj="o11yDashboardTileLink"
href={dashboardLocator?.getRedirectUrl({
dashboardId: dashboard.id,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also pass the time range for the alert here? The dashboard locator supports adding a time range.

})}
target="_blank"
>
{dashboard.title}
</EuiLink>
<EuiText color={'subdued'} size="s">
{dashboard.description}
</EuiText>
Expand Down