Skip to content

fix(text): not need fixed bounding box when contentWidth min than style.width #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(text): not need fixed bounding box when contentWidth min than style.width #1091

wants to merge 1 commit into from

Conversation

linghaoSu
Copy link

@linghaoSu linghaoSu commented Jul 24, 2024 •
edited
Loading

When overflow is set and style.width is not empty, a fixed boundingBox is used, where the x value of the boundingBox is adjusted according to style.width.

zrender/src/graphic/Text.ts

Lines 604 to 614 in 247e119

el.setBoundingRect(new BoundingRect(
adjustTextX(subElStyle.x, style.width, subElStyle.textAlign as TextAlign),
adjustTextY(subElStyle.y, calculatedLineHeight, subElStyle.textBaseline as TextVerticalAlign),
/**
* Text boundary should be the real text width.
* Otherwise, there will be extra space in the
* bounding rect calculated.
*/
contentWidth,
calculatedLineHeight
));

However, when the width of the text is smaller than the set style.width, the boundingBox will be positioned to the left, as shown in the following figure.

image

2024-07-24.23.57.17.mov

fix apache/echarts#18306

@plainheart plainheart requested a review from pissang November 11, 2024 02:18
100pah added a commit that referenced this pull request Nov 16, 2024
@100pah
fix: boundingRect.x of text is incorrect when overflow: 'truncate'.
ecff1a8 
memo info: This code used to be modified in commit bd2642e and bd2642e , where the `boundingRect.width` was modified from `style.width` to `innerWith` and then `outerWith`, but the `boundingRect.x` was not modified correspondingly. Related issue: apache/echarts#18306 . And #1091 located the problematic code successfully but the fix was not entirely correct.
100pah added a commit that referenced this pull request Nov 16, 2024
@100pah
fix: boundingRect.x of text is incorrect when overflow: 'truncate'. C…
f7cf14f 
…lose apache/echarts#18306 . And #1091 located the problematic code successfully but the fix was not entirely correct.
@100pah 100pah mentioned this pull request Nov 16, 2024
Merged
@plainheart
Copy link
Collaborator

Thank you for your contribution! It was superseded by #1100.

@plainheart plainheart closed this Nov 20, 2024
ken-zlai pushed a commit to zipline-ai/chronon that referenced this pull request Jan 20, 2025
@varant-zlai @snyk-bot
[Snyk] Upgrade echarts from 5.5.1 to 5.6.0 (#250)
97d50b3 
![snyk-top-banner](https://redirect.github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)


<h3>Snyk has created this PR to upgrade echarts from 5.5.1 to
5.6.0.</h3>

:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.

<hr/>


- The recommended version is **2 versions** ahead of your current
version.

- The recommended version was released **23 days ago**.



<details>
<summary><b>Release notes</b></summary>
<br/>
  <details>
    <summary>Package name: <b>echarts</b></summary>
    <ul>
      <li>
<b>5.6.0</b> - <a
href="https://redirect.github.com/apache/echarts/releases/tag/5.6.0">2024-12-28</a></br><ul>
<li>[Feature] [geo] [map] Support styling region in original GeoJSON
data. <a href="https://redirect.github.com/apache/echarts/issues/20564"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20564/hovercard">#20564</a> (<a
href="https://redirect.github.com/plainheart">plainheart</a>)</li>
<li>[Feature] [geo] [map] Support <code>regions[].silent</code> option.
<a href="https://redirect.github.com/apache/echarts/issues/20566"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20566/hovercard">#20566</a> (<a
href="https://redirect.github.com/Ovilia">Ovilia</a>)</li>
<li>[Feature] [axis] Support tooltip for axis label. <a
href="https://redirect.github.com/apache/echarts/issues/16315"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/16315/hovercard">#16315</a> (<a
href="https://redirect.github.com/plainheart">plainheart</a>)</li>
<li>[Feature] [text] Add <code>isTruncated</code> state property for
<code>Text</code> element. <a
href="https://redirect.github.com/ecomfe/zrender/pull/1101"
data-hovercard-type="pull_request"
data-hovercard-url="/ecomfe/zrender/pull/1101/hovercard">#1101</a> (<a
href="https://redirect.github.com/100Pah">100pah</a>)</li>
<li>[Feature] [sunburst] Add new emphasis focus strategy
<code>'relative'</code> for highlighting ancestor and descendant nodes.
<a href="https://redirect.github.com/apache/echarts/issues/20399"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20399/hovercard">#20399</a> (<a
href="https://redirect.github.com/sz-p">sz-p</a>)</li>
<li>[Feature] [axis] Add <code>showMinLine</code> /
<code>showMaxLine</code> option for <code>splitLine</code>. <a
href="https://redirect.github.com/apache/echarts/issues/20114"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20114/hovercard">#20114</a> (<a
href="https://redirect.github.com/adaelixir">adaelixir</a>)</li>
<li>[Feature] [dataZoom] Add <code>handleLabel.show</code> option. <a
href="https://redirect.github.com/apache/echarts/issues/20082"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20082/hovercard">#20082</a> (<a
href="https://redirect.github.com/Ovilia">Ovilia</a>)</li>
<li>[Feature] [calendar] Add <code>silent</code> option for
<code>dayLabel</code>/<code>monthLabel</code>/<code>yearLabel</code>. <a
href="https://redirect.github.com/apache/echarts/issues/20492"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20492/hovercard">#20492</a> (<a
href="https://redirect.github.com/plainheart">plainheart</a>)</li>
<li>[Feature] [treemap] Add <code>cursor</code> option. <a
href="https://redirect.github.com/apache/echarts/issues/20113"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20113/hovercard">#20113</a> (<a
href="https://redirect.github.com/adaelixir">adaelixir</a>)</li>
<li>[Feature] [aria] Add <code>aria.data.excludeDimensionId</code> to
exclude specific dimensions in aria-label. <a
href="https://redirect.github.com/apache/echarts/issues/20218"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20218/hovercard">#20218</a> (<a
href="https://redirect.github.com/semla">semla</a>)</li>
<li>[Feature] [aria] Add <code>role="img"</code> to chart container
element. <a
href="https://redirect.github.com/apache/echarts/issues/20050"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20050/hovercard">#20050</a> (<a
href="https://redirect.github.com/ViniciusCestarii">ViniciusCestarii</a>)</li>
<li>[Feature] [i18n] Add Swedish(SV) translation <a
href="https://redirect.github.com/apache/echarts/issues/20227"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20227/hovercard">#20227</a> (<a
href="https://redirect.github.com/NajamShehzad">NajamShehzad</a>)</li>
<li>[Feature] [i18n] Add Persian(FA) translation. <a
href="https://redirect.github.com/apache/echarts/issues/20312"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20312/hovercard">#20312</a> (<a
href="https://redirect.github.com/Ayazadeh">Ayazadeh</a>)</li>
<li>[Feature] [i18n] Improve pt-BR translation. <a
href="https://redirect.github.com/apache/echarts/issues/20348"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20348/hovercard">#20348</a> (<a
href="https://redirect.github.com/ViniciusCestarii">ViniciusCestarii</a>)</li>
<li>[Fix] [line] Reduce runtime memory cost. <a
href="https://redirect.github.com/apache/echarts/issues/20161"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20161/hovercard">#20161</a> (<a
href="https://redirect.github.com/plainheart">plainheart</a>)</li>
<li>[Fix] [line] Fix <code>areaStyle</code> skewing in stepped line
series and incorrect <code>connectNull</code> behavior <a
href="https://redirect.github.com/apache/echarts/issues/20092"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20092/hovercard">#20092</a> (<a
href="https://redirect.github.com/Ovilia">Ovilia</a>)</li>
<li>[Fix] [candlestick] Add back missing support for non-normal states
since v5.0.0. <a
href="https://redirect.github.com/apache/echarts/issues/20105"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20105/hovercard">#20105</a> (<a
href="https://redirect.github.com/plainheart">plainheart</a>)</li>
<li>[Fix] [legend] Fix legend action is not isolated from other legend
components. <a
href="https://redirect.github.com/apache/echarts/issues/20129"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20129/hovercard">#20129</a> (<a
href="https://redirect.github.com/plainheart">plainheart</a>)</li>
<li>[Fix] [bar] Fix borderColor hides bar color with large data. <a
href="https://redirect.github.com/apache/echarts/issues/20465"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20465/hovercard">#20465</a> (<a
href="https://redirect.github.com/DevitX">DevitX</a>)</li>
<li>[Fix] [pictorial] Fix zero value flipping for different axes. <a
href="https://redirect.github.com/apache/echarts/issues/20557"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20557/hovercard">#20557</a> (<a
href="https://redirect.github.com/Ovilia">Ovilia</a>)</li>
<li>[Fix] [visualMap] Fix cursor is still pointer when
<code>selectedMode</code> is disabled. <a
href="https://redirect.github.com/apache/echarts/issues/20551"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20551/hovercard">#20551</a> (<a
href="https://redirect.github.com/sz-p">sz-p</a>)</li>
<li>[Fix] [visualMap] Fix label collides with horizontal visualMap. <a
href="https://redirect.github.com/apache/echarts/issues/20249"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20249/hovercard">#20249</a> (<a
href="https://redirect.github.com/WojciechKrakowiak">WojciechKrakowiak</a>)</li>
<li>[Fix] [tooltip] Fix potential NPE when setting option with
<code>notMerge</code> strategy. <a
href="https://redirect.github.com/apache/echarts/issues/20435"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20435/hovercard">#20435</a> (<a
href="https://redirect.github.com/ktx-abhay">ktx-abhay</a>)</li>
<li>[Fix] [tooltip] Fix tooltip <code>textStyle.lineHeight</code> does
not work. <a
href="https://redirect.github.com/apache/echarts/issues/20398"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20398/hovercard">#20398</a> (<a
href="https://redirect.github.com/sz-p">sz-p</a>)</li>
<li>[Fix] [sankey] Avoid throwing errors when the <code>links</code> /
<code>nodes</code> / <code>levels</code> option is undefined. <a
href="https://redirect.github.com/apache/echarts/issues/20380"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20380/hovercard">#20380</a> (<a
href="https://redirect.github.com/sz-p">sz-p</a>)</li>
<li>[Fix] [polar] Fix unexpected clipping in polar coordinate. <a
href="https://redirect.github.com/apache/echarts/issues/20370"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20370/hovercard">#20370</a> (<a
href="https://redirect.github.com/sz-p">sz-p</a>)</li>
<li>[Fix] [boxplot] Correctly handle <code>series.encode</code> with
category axis. <a
href="https://redirect.github.com/apache/echarts/issues/20324"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20324/hovercard">#20324</a> (<a
href="https://redirect.github.com/jonoshearman">jonoshearman</a>)</li>
<li>[Fix] [sampling] Fix <code>minmax</code> sampling behavior. <a
href="https://redirect.github.com/apache/echarts/issues/20315"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20315/hovercard">#20315</a> (<a
href="https://redirect.github.com/ribeirompl">ribeirompl</a>)</li>
<li>[Fix] [gauge] Fix progress bar may be beneath the axis line. <a
href="https://redirect.github.com/apache/echarts/issues/20276"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20276/hovercard">#20276</a> (<a
href="https://redirect.github.com/kingyue737">kingyue737</a>)</li>
<li>[Fix] [axis] Fix axis ticks overflowing grid area with dataZoom. <a
href="https://redirect.github.com/apache/echarts/issues/20194"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20194/hovercard">#20194</a> (<a
href="https://redirect.github.com/Ovilia">Ovilia</a>)</li>
<li>[Fix] [axis] [time] Fix bar bandWidth with inversed time axis. <a
href="https://redirect.github.com/apache/echarts/issues/20246"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20246/hovercard">#20246</a> (<a
href="https://redirect.github.com/Ovilia">Ovilia</a>)</li>
<li>[Fix] [theme] Fix legend page text color in dark mode. <a
href="https://redirect.github.com/apache/echarts/issues/20396"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20396/hovercard">#20396</a> (<a
href="https://redirect.github.com/plainheart">plainheart</a>)</li>
<li>[Fix] [pie] Fix some labels may not show. <a
href="https://redirect.github.com/apache/echarts/issues/20074"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20074/hovercard">#20074</a> (<a
href="https://redirect.github.com/liuyunzidian">liuyunzidian</a>)</li>
<li>[Fix] [grid] Fix clipping in custom series off by pixel. <a
href="https://redirect.github.com/apache/echarts/issues/20043"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20043/hovercard">#20043</a> (<a
href="https://redirect.github.com/fandi-1205">fandi-1205</a>)</li>
<li>[Fix] [svg] Fix SVG element may be not interactable in SSR mode and
fix invalid <code>transparent</code> color issue. <a
href="https://redirect.github.com/ecomfe/zrender/issues/1076"
data-hovercard-type="pull_request"
data-hovercard-url="/ecomfe/zrender/pull/1076/hovercard">#1076</a> (<a
href="https://redirect.github.com/plainheart">plainheart</a>)</li>
<li>[Fix] [data] Fix potential NPE in the
<code>SeriesData#rawIndexOf</code> function. <a
href="https://redirect.github.com/apache/echarts/issues/20534"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20534/hovercard">#20534</a> (<a
href="https://redirect.github.com/plainheart">plainheart</a>)</li>
<li>[Fix] [text] Fix text bounding rectangle is incorrect when
<code>overflow</code> is <code>'truncate'</code>. <a
href="https://redirect.github.com/ecomfe/zrender/pull/1091"
data-hovercard-type="pull_request"
data-hovercard-url="/ecomfe/zrender/pull/1091/hovercard">#1091</a> (<a
href="https://redirect.github.com/linghaoSu">linghaoSu</a>) <a
href="https://redirect.github.com/ecomfe/zrender/pull/1100"
data-hovercard-type="pull_request"
data-hovercard-url="/ecomfe/zrender/pull/1100/hovercard">#1100</a> (<a
href="https://redirect.github.com/100Pah">100Pah</a>)</li>
<li>[Fix] [env] Fix detection for node environment. <a
href="https://redirect.github.com/ecomfe/zrender/pull/1037"
data-hovercard-type="pull_request"
data-hovercard-url="/ecomfe/zrender/pull/1037/hovercard">#1037</a> (<a
href="https://redirect.github.com/Uzlopak">Uzlopak</a>) <a
href="https://redirect.github.com/ecomfe/zrender/pull/1071"
data-hovercard-type="pull_request"
data-hovercard-url="/ecomfe/zrender/pull/1071/hovercard">#1071</a> (<a
href="https://redirect.github.com/xg-qd">xg-qd</a>) <a
href="https://redirect.github.com/ecomfe/zrender/pull/1086"
data-hovercard-type="pull_request"
data-hovercard-url="/ecomfe/zrender/pull/1086/hovercard">#1086</a> (<a
href="https://redirect.github.com/plainheart">plainheart</a>)</li>
<li>[Fix] [type] MarkLine <code>symbolOffset</code> can be a 2d array
for both symbols. <a
href="https://redirect.github.com/apache/echarts/issues/20491"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20491/hovercard">#20491</a> (<a
href="https://redirect.github.com/plainheart">plainheart</a>)</li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/ViniciusCestarii/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/ViniciusCestarii">@
ViniciusCestarii</a> made their first contribution in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2362874154" data-permission-text="Title is private"
data-url="apache/echarts#20050"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20050/hovercard"
href="https://redirect.github.com/apache/echarts/pull/20050">#20050</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/fandi-1205/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/fandi-1205">@ fandi-1205</a> made
their first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2359464529"
data-permission-text="Title is private"
data-url="apache/echarts#20043"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20043/hovercard"
href="https://redirect.github.com/apache/echarts/pull/20043">#20043</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/adaelixir/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/adaelixir">@ adaelixir</a> made their
first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2390042142"
data-permission-text="Title is private"
data-url="apache/echarts#20114"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20114/hovercard"
href="https://redirect.github.com/apache/echarts/pull/20114">#20114</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/liuyunzidian/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/liuyunzidian">@ liuyunzidian</a> made
their first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2372155691"
data-permission-text="Title is private"
data-url="apache/echarts#20074"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20074/hovercard"
href="https://redirect.github.com/apache/echarts/pull/20074">#20074</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/semla/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/semla">@ semla</a> made their first
contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2442125783"
data-permission-text="Title is private"
data-url="apache/echarts#20218"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20218/hovercard"
href="https://redirect.github.com/apache/echarts/pull/20218">#20218</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/NajamShehzad/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/NajamShehzad">@ NajamShehzad</a> made
their first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2448757186"
data-permission-text="Title is private"
data-url="apache/echarts#20227"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20227/hovercard"
href="https://redirect.github.com/apache/echarts/pull/20227">#20227</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/kingyue737/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/kingyue737">@ kingyue737</a> made
their first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2475399071"
data-permission-text="Title is private"
data-url="apache/echarts#20276"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20276/hovercard"
href="https://redirect.github.com/apache/echarts/pull/20276">#20276</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/Ayazadeh/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/Ayazadeh">@ Ayazadeh</a> made their
first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2499384271"
data-permission-text="Title is private"
data-url="apache/echarts#20312"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20312/hovercard"
href="https://redirect.github.com/apache/echarts/pull/20312">#20312</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/jonoshearman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/jonoshearman">@ jonoshearman</a> made
their first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2508444421"
data-permission-text="Title is private"
data-url="apache/echarts#20324"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20324/hovercard"
href="https://redirect.github.com/apache/echarts/pull/20324">#20324</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/sz-p/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/sz-p">@ sz-p</a> made their first
contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2545101515"
data-permission-text="Title is private"
data-url="apache/echarts#20370"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20370/hovercard"
href="https://redirect.github.com/apache/echarts/pull/20370">#20370</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/WojciechKrakowiak/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/WojciechKrakowiak">@
WojciechKrakowiak</a> made their first contribution in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2460995276" data-permission-text="Title is private"
data-url="apache/echarts#20249"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20249/hovercard"
href="https://redirect.github.com/apache/echarts/pull/20249">#20249</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/ktx-abhay/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/ktx-abhay">@ ktx-abhay</a> made their
first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2602291773"
data-permission-text="Title is private"
data-url="apache/echarts#20435"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20435/hovercard"
href="https://redirect.github.com/apache/echarts/pull/20435">#20435</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/mrginglymus/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/mrginglymus">@ mrginglymus</a> made
their first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2640413787"
data-permission-text="Title is private"
data-url="apache/echarts#20485"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20485/hovercard"
href="https://redirect.github.com/apache/echarts/pull/20485">#20485</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/DevitX/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/DevitX">@ DevitX</a> made their first
contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2625492671"
data-permission-text="Title is private"
data-url="apache/echarts#20465"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20465/hovercard"
href="https://redirect.github.com/apache/echarts/pull/20465">#20465</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/Uzlopak/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/Uzlopak">@ Uzlopak</a> made their
first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="1973960043"
data-permission-text="Title is private"
data-url="ecomfe/zrender#1037"
data-hovercard-type="pull_request"
data-hovercard-url="/ecomfe/zrender/pull/1037/hovercard"
href="https://redirect.github.com/ecomfe/zrender/pull/1037">ecomfe/zrender#1037</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/xg-qd/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/xg-qd">@ xg-qd</a> made their first
contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2220471323"
data-permission-text="Title is private"
data-url="ecomfe/zrender#1071"
data-hovercard-type="pull_request"
data-hovercard-url="/ecomfe/zrender/pull/1071/hovercard"
href="https://redirect.github.com/ecomfe/zrender/pull/1071">ecomfe/zrender#1071</a></li>
</ul>
      </li>
      <li>
<b>5.6.0-rc.1</b> - <a
href="https://redirect.github.com/apache/echarts/releases/tag/5.6.0-rc.1">2024-12-21</a></br><p>Release
5.6.0-rc.1</p>
      </li>
      <li>
<b>5.5.1</b> - <a
href="https://redirect.github.com/apache/echarts/releases/tag/5.5.1">2024-06-27</a></br><ul>
<li>[Feature] [axis] Support custom axis tick/label positions. <a
href="https://redirect.github.com/apache/echarts/issues/19919"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/19919/hovercard">#19919</a> (<a
href="https://redirect.github.com/dvdkon">dvdkon</a>) (<a
href="https://redirect.github.com/Ovilia">Ovilia</a>)</li>
<li>[Feature] [bar] Add <code>startValue</code> option. <a
href="https://redirect.github.com/apache/echarts/issues/17078"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/17078/hovercard">#17078</a> (<a
href="https://redirect.github.com/jiawulin001">jiawulin001</a>)</li>
<li>[Feature] [sankey] Add <code>itemStyle.borderRadius</code> option.
<a href="https://redirect.github.com/apache/echarts/issues/19763"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/19763/hovercard">#19763</a> (<a
href="https://redirect.github.com/deftliang">deftliang</a>)</li>
<li>[Feature] [time] Add meridian template <code>{a}/{A}</code>. <a
href="https://redirect.github.com/apache/echarts/issues/19888"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/19888/hovercard">#19888</a> (<a
href="https://redirect.github.com/maurodesouza">maurodesouza</a>)</li>
<li>[Feature] [geo] Add <code>totalZoom</code> parameter for the
<code>georoam</code> event. <a
href="https://redirect.github.com/apache/echarts/issues/19837"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/19837/hovercard">#19837</a> (<a
href="https://redirect.github.com/zhaoxinggang">zhaoxinggang</a>)</li>
<li>[Feature] [treemap] Add <code>scaleLimit</code> option to limit the
zooming. <a
href="https://redirect.github.com/apache/echarts/issues/18304"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/18304/hovercard">#18304</a> (<a
href="https://redirect.github.com/liuyizhou">liuyizhou</a>)</li>
<li>[Fix] [series] Avoid error caused by
<code>seriesData.getLinkedData</code>. <a
href="https://redirect.github.com/apache/echarts/issues/19901"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/19901/hovercard">#19901</a> (<a
href="https://redirect.github.com/plainheart">plainheart</a>)</li>
<li>[Fix] [marker] Fix marker label formatter can't get series
information. <a
href="https://redirect.github.com/apache/echarts/issues/19898"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/19898/hovercard">#19898</a> (<a
href="https://redirect.github.com/plainheart">plainheart</a>)</li>
<li>[Fix] [aria] Avoid error in SSR mode. <a
href="https://redirect.github.com/apache/echarts/issues/19892"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/19892/hovercard">#19892</a> (<a
href="https://redirect.github.com/OverflowCat">OverflowCat</a>)</li>
<li>[Fix] [data] Avoid error when using BigInt values. <a
href="https://redirect.github.com/apache/echarts/issues/19847"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/19847/hovercard">#19847</a> (<a
href="https://redirect.github.com/zettca">zettca</a>)</li>
<li>[Fix] [pie] Fix <code>endAngle</code> is not applied on the empty
circle. <a
href="https://redirect.github.com/apache/echarts/issues/19642"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/19642/hovercard">#19642</a> (<a
href="https://redirect.github.com/plainheart">plainheart</a>)</li>
<li>[Fix] [toolbox] Fix uncaught reference error in the environment that
<code>MouseEvent</code> doesn't exist. <a
href="https://redirect.github.com/apache/echarts/issues/19620"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/19620/hovercard">#19620</a> (<a
href="https://redirect.github.com/plainheart">plainheart</a>)</li>
<li>[Fix] [tooltip] Fix tooltip XSS issue when legend name is HTML
string. <a
href="https://redirect.github.com/apache/echarts/issues/20045"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20045/hovercard">#20045</a> (<a
href="https://redirect.github.com/plainheart">plainheart</a>)</li>
<li>[Fix] [type] Fix that in users' .d.ts
<code>import('echarts/types/dist/shared')</code> can not visit
<code>'echarts/types/dist/shared.d.ts'</code> since v5.5.0. <a
href="https://redirect.github.com/apache/echarts/issues/20030"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/20030/hovercard">#20030</a> (<a
href="https://redirect.github.com/100pah">100pah</a>)</li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/miracleren/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/miracleren">@ miracleren</a> made
their first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2032064429"
data-permission-text="Title is private"
data-url="apache/echarts#19373"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/19373/hovercard"
href="https://redirect.github.com/apache/echarts/pull/19373">#19373</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/zhaoxinggang/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/zhaoxinggang">@ zhaoxinggang</a> made
their first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2245140925"
data-permission-text="Title is private"
data-url="apache/echarts#19837"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/19837/hovercard"
href="https://redirect.github.com/apache/echarts/pull/19837">#19837</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/zettca/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/zettca">@ zettca</a> made their first
contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2250125400"
data-permission-text="Title is private"
data-url="apache/echarts#19847"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/19847/hovercard"
href="https://redirect.github.com/apache/echarts/pull/19847">#19847</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/OverflowCat/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/OverflowCat">@ OverflowCat</a> made
their first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2278620447"
data-permission-text="Title is private"
data-url="apache/echarts#19892"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/19892/hovercard"
href="https://redirect.github.com/apache/echarts/pull/19892">#19892</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/maurodesouza/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/maurodesouza">@ maurodesouza</a> made
their first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2274207439"
data-permission-text="Title is private"
data-url="apache/echarts#19888"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/19888/hovercard"
href="https://redirect.github.com/apache/echarts/pull/19888">#19888</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/deftliang/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/deftliang">@ deftliang</a> made their
first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2209804593"
data-permission-text="Title is private"
data-url="apache/echarts#19763"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/19763/hovercard"
href="https://redirect.github.com/apache/echarts/pull/19763">#19763</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/liuyizhou/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/liuyizhou">@ liuyizhou</a> made their
first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="1596505934"
data-permission-text="Title is private"
data-url="apache/echarts#18304"
data-hovercard-type="pull_request"
data-hovercard-url="/apache/echarts/pull/18304/hovercard"
href="https://redirect.github.com/apache/echarts/pull/18304">#18304</a></li>
</ul>
      </li>
    </ul>
from <a
href="https://redirect.github.com/apache/echarts/releases">echarts
GitHub release notes</a>
  </details>
</details>

---

> [!IMPORTANT]
>
> - Check the changes in this PR to ensure they won't cause issues with
your project.
> - This PR was automatically created by Snyk using the credentials of a
real user.
> - Snyk has automatically assigned this pull request, [set who gets
assigned](/settings/integration).

---

**Note:** _You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs._

**For more information:** <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiI3Yzc0OGEwYi0xNjJhLTQ0N2MtYmQ5YS05MzQ5ZTBhNDNkNzciLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjdjNzQ4YTBiLTE2MmEtNDQ3Yy1iZDlhLTkzNDllMGE0M2Q3NyJ9fQ=="
width="0" height="0"/>

> - 🧐 [View latest project
report](https://app.snyk.io/org/varant-zlai/project/f4bdc116-d05b-4937-96b5-b1f9a02872e5?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 👩‍💻 [Set who automatically gets
assigned](https://app.snyk.io/org/varant-zlai/project/f4bdc116-d05b-4937-96b5-b1f9a02872e5/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr/)
> - 📜 [Customise PR
templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates?utm_source=&utm_content=fix-pr-template)
> - 🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/varant-zlai/project/f4bdc116-d05b-4937-96b5-b1f9a02872e5/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/varant-zlai/project/f4bdc116-d05b-4937-96b5-b1f9a02872e5/settings/integration?pkg&#x3D;echarts&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)

[//]: #
'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"echarts","from":"5.5.1","to":"5.6.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"7c748a0b-162a-447c-bd9a-9349e0a43d77","prPublicId":"7c748a0b-162a-447c-bd9a-9349e0a43d77","packageManager":"npm","priorityScoreList":[],"projectPublicId":"f4bdc116-d05b-4937-96b5-b1f9a02872e5","projectUrl":"https://app.snyk.io/org/varant-zlai/project/f4bdc116-d05b-4937-96b5-b1f9a02872e5?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":2,"publishedDate":"2024-12-28T07:21:42.839Z"},"vulns":[]}'

Co-authored-by: snyk-bot <[email protected]>
@linghaoSu linghaoSu deleted the fix/overflow-truncate-boundingbox branch February 8, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pissang pissang Awaiting requested review from pissang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Overflow truncate breaks axis label click target position
2 participants
@linghaoSu @plainheart