wip

[tchow-zlai]

Summary

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Chores
  • Updated build configuration to explicitly use UTF-8 for Java compilation.
  • Retained Java 11 target; no changes to runtime behavior or public interfaces.
  • Change affects build process only; no user-facing functionality modified.
  • No action required from users; existing workflows continue to work as before.

[coderabbitai]

Walkthrough

Adds explicit UTF-8 encoding to Java compilation by inserting "-encoding", "utf8" into javacOptions in build.mill’s BaseModule. No runtime logic or API changes.

Changes

Cohort / File(s)	Summary
Build configuration build.mill	In BaseModule.javacOptions, added "-encoding", "utf8"; retained "-target", "11" (with trailing comma). Build-only change; no public API/runtime impact.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

Mill hums a tune in UTF-8 light,
Javac now reads every glyph right.
No APIs stirred, no runtime fight—
Just cleaner builds, crisp and bright.
Commit done; ship it tonight! ✨

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch tchow/chronon-symbol

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

build.mill (3)

119-123: Prefer --release 11; use canonical UTF-8; drop trailing comma

More robust targeting across JDKs; clearer charset; consistent style.

-  def javacOptions = Seq(
-    "-source", "11",
-    "-target", "11",
-    "-encoding", "utf8",
-  )
+  def javacOptions = Seq(
+    "--release", "11",
+    "-encoding", "UTF-8"
+  )

---

110-117: Also set scalac encoding

Keep Scala sources consistent with Java.

 def scalacOptions = Seq(
   "-deprecation",
   "-feature",
   "-unchecked",
   "-language:implicitConversions",
   "-language:postfixOps",
-  "-language:reflectiveCalls"
+  "-language:reflectiveCalls",
+  "-encoding", "UTF-8"
 )

---

138-155: Propagate encoding to tests

BaseTestModule doesn’t inherit BaseModule’s options; consider mixing it in or adding the same -encoding flags here to avoid drift.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e227c75 and 2d29d07.

📒 Files selected for processing (1)

• build.mill (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (15)

• GitHub Check: cloud_gcp_tests
• GitHub Check: cloud_aws_tests
• GitHub Check: join_tests
• GitHub Check: groupby_tests
• GitHub Check: analyzer_tests
• GitHub Check: streaming_tests
• GitHub Check: kv_store_tests
• GitHub Check: spark_tests
• GitHub Check: stats_tests
• GitHub Check: flink_tests
• GitHub Check: udafs_tests
• GitHub Check: online_tests
• GitHub Check: batch_tests
• GitHub Check: fetcher_tests
• GitHub Check: enforce_triggered_workflows