Relax tslib requirement specifier #20485

mrginglymus · 2024-11-07T09:31:56Z

Brief Information

This pull request is in the type of:

bug fixing
new feature
others

What does this PR do?

Relax dependency specifier of tslib

Fixed issues

Details

Before: What was the problem?

I was testing my library with vite v6.beta, and found that [email protected] did not work; later version of tslib did work.

After: How does it behave after the fixing?

echarts now allows users to pick their own version of tslib - so a. it now works with vite v6 and b. users aren't unecessarily shipping two copies of tslib

Document Info

One of the following should be checked.

This PR doesn't relate to document changes
The document should be updated later
The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

This PR depends on ZRender changes (Relax tslib requirement specifier ecomfe/zrender#1097).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

Please squash the commits into a single one when merging.

Other information

echarts-bot · 2024-11-07T09:32:02Z

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

github-actions · 2024-11-08T02:39:35Z

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20485@c939973

echarts-bot · 2024-11-08T07:32:49Z

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

100pah · 2024-11-12T14:47:33Z

Curious about why tslib 2.3.0 doesn't work.

I can not reproduce it with [email protected].
Could I have more info to reproduce it? @mrginglymus

What I've done is:

npm i -D [email protected]
npm i echarts
touch index.html

            <!DOCTYPE html>
            <html>
                <head>
                    <meta charset="utf-8">
                    <meta name="viewport" content="width=device-width, initial-scale=1" />
                    <script src="./node_modules/echarts/dist/echarts.js"></script>
                </head>
                <body>
                    <p>good</p>
                    <div id="main" style="height: 500px; "></div>
                    <script>
                        var chart = echarts.init(document.getElementById('main'));
                        chart.setOption({
                            angleAxis: {
                                type: 'category',
                                data: ['周一', '周二', '周三', '周四', '周五', '周六', '周日'],
                            },
                            tooltip: {},
                            radiusAxis: {},
                            polar: { center: ['40%', '50%'] },
                            series: [{
                                type: 'bar',
                                data: [1, 2, '-', 3, 0, 5, 7],
                                coordinateSystem: 'polar'
                            }]
                        });
                        chart.on('click', function (params) {
                            console.log(params);
                        });
                    </script>
                </body>
            </html>

npx vite

And the chart displayed normally.

@Ovilia @plainheart

Does this modification lead to breaking change?
Or should we do full test against different version of tslib? or check every breaking changes of tslib since 2.3.0 to latest?
Or should we make this change in a patch version if it might introduce breaking or error?

mrginglymus · 2024-11-12T15:17:45Z

Honestly I didn't spend too much time on working out the why, only the what.

The error as spotted was this:

I will see if I can dig into what was wrong with vite here, as it may be worth an issue on their end as a regression.

Aside from compatibility in whatever obscure set of conditions I've discovered, the more significant benefit of this change is allowing users to ship only one copy of tslib; I currently use tslib@^2.5.0 to support decorators and whilst the size of tslib is insignificant compared to the echarts stack, it still bugs me to be shipping two copies.

100pah · 2024-11-13T08:53:57Z

Some memos:

Found that at present echarts only uses __extends function of tslib. (by searching from "tslib in echarts/lib.).
About bundle size: After tree shaking (tested in [email protected], tsc -b && vite build), only used functions of tslib will be included in bundle. That is only __extends (and extendStatics, which is called by __extends internally) is included. So the bundle size is probably not a concern till now.
Compatibility if changing to "tslib": "^x.x.x": Checked the commit log of __extends on git, there's no breaking. Thus this change does not break echarts.

Use different versions of tslib in one JS context: (tested in [email protected], tsc -b && vite build) , the built bundle is like this :

// At the top scope of the bundle file dist/assets/index-JsGP8STl.js
// Two tslib are included but the name are modified to avoid conflict.
var extendStatics$1 = function(d, b) { /* ... */ };
function __extends$1(d, b) { /* ... */ }
/* ... */
var extendStatics = function(d, b) { /* ... */ };
function __extends(d, b) { /* ... */ }

![snyk-top-banner](https://redirect.github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123) <h3>Snyk has created this PR to upgrade echarts from 5.5.1 to 5.6.0.</h3> :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. <hr/> - The recommended version is **2 versions** ahead of your current version. - The recommended version was released **23 days ago**. <details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>echarts</b></summary> <ul> <li> <b>5.6.0</b> - <a href="https://redirect.github.com/apache/echarts/releases/tag/5.6.0">2024-12-28</a></br><ul> <li>[Feature] [geo] [map] Support styling region in original GeoJSON data. <a href="https://redirect.github.com/apache/echarts/issues/20564" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20564/hovercard">#20564</a> (<a href="https://redirect.github.com/plainheart">plainheart</a>)</li> <li>[Feature] [geo] [map] Support <code>regions[].silent</code> option. <a href="https://redirect.github.com/apache/echarts/issues/20566" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20566/hovercard">#20566</a> (<a href="https://redirect.github.com/Ovilia">Ovilia</a>)</li> <li>[Feature] [axis] Support tooltip for axis label. <a href="https://redirect.github.com/apache/echarts/issues/16315" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/16315/hovercard">#16315</a> (<a href="https://redirect.github.com/plainheart">plainheart</a>)</li> <li>[Feature] [text] Add <code>isTruncated</code> state property for <code>Text</code> element. <a href="https://redirect.github.com/ecomfe/zrender/pull/1101" data-hovercard-type="pull_request" data-hovercard-url="/ecomfe/zrender/pull/1101/hovercard">#1101</a> (<a href="https://redirect.github.com/100Pah">100pah</a>)</li> <li>[Feature] [sunburst] Add new emphasis focus strategy <code>'relative'</code> for highlighting ancestor and descendant nodes. <a href="https://redirect.github.com/apache/echarts/issues/20399" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20399/hovercard">#20399</a> (<a href="https://redirect.github.com/sz-p">sz-p</a>)</li> <li>[Feature] [axis] Add <code>showMinLine</code> / <code>showMaxLine</code> option for <code>splitLine</code>. <a href="https://redirect.github.com/apache/echarts/issues/20114" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20114/hovercard">#20114</a> (<a href="https://redirect.github.com/adaelixir">adaelixir</a>)</li> <li>[Feature] [dataZoom] Add <code>handleLabel.show</code> option. <a href="https://redirect.github.com/apache/echarts/issues/20082" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20082/hovercard">#20082</a> (<a href="https://redirect.github.com/Ovilia">Ovilia</a>)</li> <li>[Feature] [calendar] Add <code>silent</code> option for <code>dayLabel</code>/<code>monthLabel</code>/<code>yearLabel</code>. <a href="https://redirect.github.com/apache/echarts/issues/20492" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20492/hovercard">#20492</a> (<a href="https://redirect.github.com/plainheart">plainheart</a>)</li> <li>[Feature] [treemap] Add <code>cursor</code> option. <a href="https://redirect.github.com/apache/echarts/issues/20113" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20113/hovercard">#20113</a> (<a href="https://redirect.github.com/adaelixir">adaelixir</a>)</li> <li>[Feature] [aria] Add <code>aria.data.excludeDimensionId</code> to exclude specific dimensions in aria-label. <a href="https://redirect.github.com/apache/echarts/issues/20218" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20218/hovercard">#20218</a> (<a href="https://redirect.github.com/semla">semla</a>)</li> <li>[Feature] [aria] Add <code>role="img"</code> to chart container element. <a href="https://redirect.github.com/apache/echarts/issues/20050" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20050/hovercard">#20050</a> (<a href="https://redirect.github.com/ViniciusCestarii">ViniciusCestarii</a>)</li> <li>[Feature] [i18n] Add Swedish(SV) translation <a href="https://redirect.github.com/apache/echarts/issues/20227" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20227/hovercard">#20227</a> (<a href="https://redirect.github.com/NajamShehzad">NajamShehzad</a>)</li> <li>[Feature] [i18n] Add Persian(FA) translation. <a href="https://redirect.github.com/apache/echarts/issues/20312" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20312/hovercard">#20312</a> (<a href="https://redirect.github.com/Ayazadeh">Ayazadeh</a>)</li> <li>[Feature] [i18n] Improve pt-BR translation. <a href="https://redirect.github.com/apache/echarts/issues/20348" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20348/hovercard">#20348</a> (<a href="https://redirect.github.com/ViniciusCestarii">ViniciusCestarii</a>)</li> <li>[Fix] [line] Reduce runtime memory cost. <a href="https://redirect.github.com/apache/echarts/issues/20161" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20161/hovercard">#20161</a> (<a href="https://redirect.github.com/plainheart">plainheart</a>)</li> <li>[Fix] [line] Fix <code>areaStyle</code> skewing in stepped line series and incorrect <code>connectNull</code> behavior <a href="https://redirect.github.com/apache/echarts/issues/20092" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20092/hovercard">#20092</a> (<a href="https://redirect.github.com/Ovilia">Ovilia</a>)</li> <li>[Fix] [candlestick] Add back missing support for non-normal states since v5.0.0. <a href="https://redirect.github.com/apache/echarts/issues/20105" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20105/hovercard">#20105</a> (<a href="https://redirect.github.com/plainheart">plainheart</a>)</li> <li>[Fix] [legend] Fix legend action is not isolated from other legend components. <a href="https://redirect.github.com/apache/echarts/issues/20129" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20129/hovercard">#20129</a> (<a href="https://redirect.github.com/plainheart">plainheart</a>)</li> <li>[Fix] [bar] Fix borderColor hides bar color with large data. <a href="https://redirect.github.com/apache/echarts/issues/20465" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20465/hovercard">#20465</a> (<a href="https://redirect.github.com/DevitX">DevitX</a>)</li> <li>[Fix] [pictorial] Fix zero value flipping for different axes. <a href="https://redirect.github.com/apache/echarts/issues/20557" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20557/hovercard">#20557</a> (<a href="https://redirect.github.com/Ovilia">Ovilia</a>)</li> <li>[Fix] [visualMap] Fix cursor is still pointer when <code>selectedMode</code> is disabled. <a href="https://redirect.github.com/apache/echarts/issues/20551" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20551/hovercard">#20551</a> (<a href="https://redirect.github.com/sz-p">sz-p</a>)</li> <li>[Fix] [visualMap] Fix label collides with horizontal visualMap. <a href="https://redirect.github.com/apache/echarts/issues/20249" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20249/hovercard">#20249</a> (<a href="https://redirect.github.com/WojciechKrakowiak">WojciechKrakowiak</a>)</li> <li>[Fix] [tooltip] Fix potential NPE when setting option with <code>notMerge</code> strategy. <a href="https://redirect.github.com/apache/echarts/issues/20435" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20435/hovercard">#20435</a> (<a href="https://redirect.github.com/ktx-abhay">ktx-abhay</a>)</li> <li>[Fix] [tooltip] Fix tooltip <code>textStyle.lineHeight</code> does not work. <a href="https://redirect.github.com/apache/echarts/issues/20398" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20398/hovercard">#20398</a> (<a href="https://redirect.github.com/sz-p">sz-p</a>)</li> <li>[Fix] [sankey] Avoid throwing errors when the <code>links</code> / <code>nodes</code> / <code>levels</code> option is undefined. <a href="https://redirect.github.com/apache/echarts/issues/20380" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20380/hovercard">#20380</a> (<a href="https://redirect.github.com/sz-p">sz-p</a>)</li> <li>[Fix] [polar] Fix unexpected clipping in polar coordinate. <a href="https://redirect.github.com/apache/echarts/issues/20370" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20370/hovercard">#20370</a> (<a href="https://redirect.github.com/sz-p">sz-p</a>)</li> <li>[Fix] [boxplot] Correctly handle <code>series.encode</code> with category axis. <a href="https://redirect.github.com/apache/echarts/issues/20324" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20324/hovercard">#20324</a> (<a href="https://redirect.github.com/jonoshearman">jonoshearman</a>)</li> <li>[Fix] [sampling] Fix <code>minmax</code> sampling behavior. <a href="https://redirect.github.com/apache/echarts/issues/20315" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20315/hovercard">#20315</a> (<a href="https://redirect.github.com/ribeirompl">ribeirompl</a>)</li> <li>[Fix] [gauge] Fix progress bar may be beneath the axis line. <a href="https://redirect.github.com/apache/echarts/issues/20276" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20276/hovercard">#20276</a> (<a href="https://redirect.github.com/kingyue737">kingyue737</a>)</li> <li>[Fix] [axis] Fix axis ticks overflowing grid area with dataZoom. <a href="https://redirect.github.com/apache/echarts/issues/20194" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20194/hovercard">#20194</a> (<a href="https://redirect.github.com/Ovilia">Ovilia</a>)</li> <li>[Fix] [axis] [time] Fix bar bandWidth with inversed time axis. <a href="https://redirect.github.com/apache/echarts/issues/20246" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20246/hovercard">#20246</a> (<a href="https://redirect.github.com/Ovilia">Ovilia</a>)</li> <li>[Fix] [theme] Fix legend page text color in dark mode. <a href="https://redirect.github.com/apache/echarts/issues/20396" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20396/hovercard">#20396</a> (<a href="https://redirect.github.com/plainheart">plainheart</a>)</li> <li>[Fix] [pie] Fix some labels may not show. <a href="https://redirect.github.com/apache/echarts/issues/20074" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20074/hovercard">#20074</a> (<a href="https://redirect.github.com/liuyunzidian">liuyunzidian</a>)</li> <li>[Fix] [grid] Fix clipping in custom series off by pixel. <a href="https://redirect.github.com/apache/echarts/issues/20043" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20043/hovercard">#20043</a> (<a href="https://redirect.github.com/fandi-1205">fandi-1205</a>)</li> <li>[Fix] [svg] Fix SVG element may be not interactable in SSR mode and fix invalid <code>transparent</code> color issue. <a href="https://redirect.github.com/ecomfe/zrender/issues/1076" data-hovercard-type="pull_request" data-hovercard-url="/ecomfe/zrender/pull/1076/hovercard">#1076</a> (<a href="https://redirect.github.com/plainheart">plainheart</a>)</li> <li>[Fix] [data] Fix potential NPE in the <code>SeriesData#rawIndexOf</code> function. <a href="https://redirect.github.com/apache/echarts/issues/20534" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20534/hovercard">#20534</a> (<a href="https://redirect.github.com/plainheart">plainheart</a>)</li> <li>[Fix] [text] Fix text bounding rectangle is incorrect when <code>overflow</code> is <code>'truncate'</code>. <a href="https://redirect.github.com/ecomfe/zrender/pull/1091" data-hovercard-type="pull_request" data-hovercard-url="/ecomfe/zrender/pull/1091/hovercard">#1091</a> (<a href="https://redirect.github.com/linghaoSu">linghaoSu</a>) <a href="https://redirect.github.com/ecomfe/zrender/pull/1100" data-hovercard-type="pull_request" data-hovercard-url="/ecomfe/zrender/pull/1100/hovercard">#1100</a> (<a href="https://redirect.github.com/100Pah">100Pah</a>)</li> <li>[Fix] [env] Fix detection for node environment. <a href="https://redirect.github.com/ecomfe/zrender/pull/1037" data-hovercard-type="pull_request" data-hovercard-url="/ecomfe/zrender/pull/1037/hovercard">#1037</a> (<a href="https://redirect.github.com/Uzlopak">Uzlopak</a>) <a href="https://redirect.github.com/ecomfe/zrender/pull/1071" data-hovercard-type="pull_request" data-hovercard-url="/ecomfe/zrender/pull/1071/hovercard">#1071</a> (<a href="https://redirect.github.com/xg-qd">xg-qd</a>) <a href="https://redirect.github.com/ecomfe/zrender/pull/1086" data-hovercard-type="pull_request" data-hovercard-url="/ecomfe/zrender/pull/1086/hovercard">#1086</a> (<a href="https://redirect.github.com/plainheart">plainheart</a>)</li> <li>[Fix] [type] MarkLine <code>symbolOffset</code> can be a 2d array for both symbols. <a href="https://redirect.github.com/apache/echarts/issues/20491" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20491/hovercard">#20491</a> (<a href="https://redirect.github.com/plainheart">plainheart</a>)</li> </ul> <h2>New Contributors</h2> <ul> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/ViniciusCestarii/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/ViniciusCestarii">@ ViniciusCestarii</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2362874154" data-permission-text="Title is private" data-url="apache/echarts#20050" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20050/hovercard" href="https://redirect.github.com/apache/echarts/pull/20050">#20050</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/fandi-1205/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/fandi-1205">@ fandi-1205</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2359464529" data-permission-text="Title is private" data-url="apache/echarts#20043" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20043/hovercard" href="https://redirect.github.com/apache/echarts/pull/20043">#20043</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/adaelixir/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/adaelixir">@ adaelixir</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2390042142" data-permission-text="Title is private" data-url="apache/echarts#20114" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20114/hovercard" href="https://redirect.github.com/apache/echarts/pull/20114">#20114</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/liuyunzidian/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/liuyunzidian">@ liuyunzidian</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2372155691" data-permission-text="Title is private" data-url="apache/echarts#20074" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20074/hovercard" href="https://redirect.github.com/apache/echarts/pull/20074">#20074</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/semla/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/semla">@ semla</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2442125783" data-permission-text="Title is private" data-url="apache/echarts#20218" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20218/hovercard" href="https://redirect.github.com/apache/echarts/pull/20218">#20218</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/NajamShehzad/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/NajamShehzad">@ NajamShehzad</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2448757186" data-permission-text="Title is private" data-url="apache/echarts#20227" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20227/hovercard" href="https://redirect.github.com/apache/echarts/pull/20227">#20227</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/kingyue737/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/kingyue737">@ kingyue737</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2475399071" data-permission-text="Title is private" data-url="apache/echarts#20276" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20276/hovercard" href="https://redirect.github.com/apache/echarts/pull/20276">#20276</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/Ayazadeh/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/Ayazadeh">@ Ayazadeh</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2499384271" data-permission-text="Title is private" data-url="apache/echarts#20312" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20312/hovercard" href="https://redirect.github.com/apache/echarts/pull/20312">#20312</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/jonoshearman/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/jonoshearman">@ jonoshearman</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2508444421" data-permission-text="Title is private" data-url="apache/echarts#20324" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20324/hovercard" href="https://redirect.github.com/apache/echarts/pull/20324">#20324</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/sz-p/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/sz-p">@ sz-p</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2545101515" data-permission-text="Title is private" data-url="apache/echarts#20370" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20370/hovercard" href="https://redirect.github.com/apache/echarts/pull/20370">#20370</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/WojciechKrakowiak/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/WojciechKrakowiak">@ WojciechKrakowiak</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2460995276" data-permission-text="Title is private" data-url="apache/echarts#20249" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20249/hovercard" href="https://redirect.github.com/apache/echarts/pull/20249">#20249</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/ktx-abhay/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/ktx-abhay">@ ktx-abhay</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2602291773" data-permission-text="Title is private" data-url="apache/echarts#20435" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20435/hovercard" href="https://redirect.github.com/apache/echarts/pull/20435">#20435</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/mrginglymus/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/mrginglymus">@ mrginglymus</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2640413787" data-permission-text="Title is private" data-url="apache/echarts#20485" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20485/hovercard" href="https://redirect.github.com/apache/echarts/pull/20485">#20485</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/DevitX/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/DevitX">@ DevitX</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2625492671" data-permission-text="Title is private" data-url="apache/echarts#20465" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20465/hovercard" href="https://redirect.github.com/apache/echarts/pull/20465">#20465</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/Uzlopak/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/Uzlopak">@ Uzlopak</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1973960043" data-permission-text="Title is private" data-url="ecomfe/zrender#1037" data-hovercard-type="pull_request" data-hovercard-url="/ecomfe/zrender/pull/1037/hovercard" href="https://redirect.github.com/ecomfe/zrender/pull/1037">ecomfe/zrender#1037</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/xg-qd/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/xg-qd">@ xg-qd</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2220471323" data-permission-text="Title is private" data-url="ecomfe/zrender#1071" data-hovercard-type="pull_request" data-hovercard-url="/ecomfe/zrender/pull/1071/hovercard" href="https://redirect.github.com/ecomfe/zrender/pull/1071">ecomfe/zrender#1071</a></li> </ul> </li> <li> <b>5.6.0-rc.1</b> - <a href="https://redirect.github.com/apache/echarts/releases/tag/5.6.0-rc.1">2024-12-21</a></br><p>Release 5.6.0-rc.1</p> </li> <li> <b>5.5.1</b> - <a href="https://redirect.github.com/apache/echarts/releases/tag/5.5.1">2024-06-27</a></br><ul> <li>[Feature] [axis] Support custom axis tick/label positions. <a href="https://redirect.github.com/apache/echarts/issues/19919" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/19919/hovercard">#19919</a> (<a href="https://redirect.github.com/dvdkon">dvdkon</a>) (<a href="https://redirect.github.com/Ovilia">Ovilia</a>)</li> <li>[Feature] [bar] Add <code>startValue</code> option. <a href="https://redirect.github.com/apache/echarts/issues/17078" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/17078/hovercard">#17078</a> (<a href="https://redirect.github.com/jiawulin001">jiawulin001</a>)</li> <li>[Feature] [sankey] Add <code>itemStyle.borderRadius</code> option. <a href="https://redirect.github.com/apache/echarts/issues/19763" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/19763/hovercard">#19763</a> (<a href="https://redirect.github.com/deftliang">deftliang</a>)</li> <li>[Feature] [time] Add meridian template <code>{a}/{A}</code>. <a href="https://redirect.github.com/apache/echarts/issues/19888" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/19888/hovercard">#19888</a> (<a href="https://redirect.github.com/maurodesouza">maurodesouza</a>)</li> <li>[Feature] [geo] Add <code>totalZoom</code> parameter for the <code>georoam</code> event. <a href="https://redirect.github.com/apache/echarts/issues/19837" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/19837/hovercard">#19837</a> (<a href="https://redirect.github.com/zhaoxinggang">zhaoxinggang</a>)</li> <li>[Feature] [treemap] Add <code>scaleLimit</code> option to limit the zooming. <a href="https://redirect.github.com/apache/echarts/issues/18304" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/18304/hovercard">#18304</a> (<a href="https://redirect.github.com/liuyizhou">liuyizhou</a>)</li> <li>[Fix] [series] Avoid error caused by <code>seriesData.getLinkedData</code>. <a href="https://redirect.github.com/apache/echarts/issues/19901" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/19901/hovercard">#19901</a> (<a href="https://redirect.github.com/plainheart">plainheart</a>)</li> <li>[Fix] [marker] Fix marker label formatter can't get series information. <a href="https://redirect.github.com/apache/echarts/issues/19898" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/19898/hovercard">#19898</a> (<a href="https://redirect.github.com/plainheart">plainheart</a>)</li> <li>[Fix] [aria] Avoid error in SSR mode. <a href="https://redirect.github.com/apache/echarts/issues/19892" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/19892/hovercard">#19892</a> (<a href="https://redirect.github.com/OverflowCat">OverflowCat</a>)</li> <li>[Fix] [data] Avoid error when using BigInt values. <a href="https://redirect.github.com/apache/echarts/issues/19847" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/19847/hovercard">#19847</a> (<a href="https://redirect.github.com/zettca">zettca</a>)</li> <li>[Fix] [pie] Fix <code>endAngle</code> is not applied on the empty circle. <a href="https://redirect.github.com/apache/echarts/issues/19642" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/19642/hovercard">#19642</a> (<a href="https://redirect.github.com/plainheart">plainheart</a>)</li> <li>[Fix] [toolbox] Fix uncaught reference error in the environment that <code>MouseEvent</code> doesn't exist. <a href="https://redirect.github.com/apache/echarts/issues/19620" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/19620/hovercard">#19620</a> (<a href="https://redirect.github.com/plainheart">plainheart</a>)</li> <li>[Fix] [tooltip] Fix tooltip XSS issue when legend name is HTML string. <a href="https://redirect.github.com/apache/echarts/issues/20045" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20045/hovercard">#20045</a> (<a href="https://redirect.github.com/plainheart">plainheart</a>)</li> <li>[Fix] [type] Fix that in users' .d.ts <code>import('echarts/types/dist/shared')</code> can not visit <code>'echarts/types/dist/shared.d.ts'</code> since v5.5.0. <a href="https://redirect.github.com/apache/echarts/issues/20030" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/20030/hovercard">#20030</a> (<a href="https://redirect.github.com/100pah">100pah</a>)</li> </ul> <h2>New Contributors</h2> <ul> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/miracleren/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/miracleren">@ miracleren</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2032064429" data-permission-text="Title is private" data-url="apache/echarts#19373" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/19373/hovercard" href="https://redirect.github.com/apache/echarts/pull/19373">#19373</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/zhaoxinggang/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/zhaoxinggang">@ zhaoxinggang</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2245140925" data-permission-text="Title is private" data-url="apache/echarts#19837" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/19837/hovercard" href="https://redirect.github.com/apache/echarts/pull/19837">#19837</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/zettca/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/zettca">@ zettca</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2250125400" data-permission-text="Title is private" data-url="apache/echarts#19847" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/19847/hovercard" href="https://redirect.github.com/apache/echarts/pull/19847">#19847</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/OverflowCat/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/OverflowCat">@ OverflowCat</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2278620447" data-permission-text="Title is private" data-url="apache/echarts#19892" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/19892/hovercard" href="https://redirect.github.com/apache/echarts/pull/19892">#19892</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/maurodesouza/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/maurodesouza">@ maurodesouza</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2274207439" data-permission-text="Title is private" data-url="apache/echarts#19888" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/19888/hovercard" href="https://redirect.github.com/apache/echarts/pull/19888">#19888</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/deftliang/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/deftliang">@ deftliang</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2209804593" data-permission-text="Title is private" data-url="apache/echarts#19763" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/19763/hovercard" href="https://redirect.github.com/apache/echarts/pull/19763">#19763</a></li> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/liuyizhou/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/liuyizhou">@ liuyizhou</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1596505934" data-permission-text="Title is private" data-url="apache/echarts#18304" data-hovercard-type="pull_request" data-hovercard-url="/apache/echarts/pull/18304/hovercard" href="https://redirect.github.com/apache/echarts/pull/18304">#18304</a></li> </ul> </li> </ul> from <a href="https://redirect.github.com/apache/echarts/releases">echarts GitHub release notes</a> </details> </details> --- > [!IMPORTANT] > > - Check the changes in this PR to ensure they won't cause issues with your project. > - This PR was automatically created by Snyk using the credentials of a real user. > - Snyk has automatically assigned this pull request, [set who gets assigned](/settings/integration). --- **Note:** _You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs._ **For more information:** <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiI3Yzc0OGEwYi0xNjJhLTQ0N2MtYmQ5YS05MzQ5ZTBhNDNkNzciLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjdjNzQ4YTBiLTE2MmEtNDQ3Yy1iZDlhLTkzNDllMGE0M2Q3NyJ9fQ==" width="0" height="0"/> > - 🧐 [View latest project report](https://app.snyk.io/org/varant-zlai/project/f4bdc116-d05b-4937-96b5-b1f9a02872e5?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 👩‍💻 [Set who automatically gets assigned](https://app.snyk.io/org/varant-zlai/project/f4bdc116-d05b-4937-96b5-b1f9a02872e5/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr/) > - 📜 [Customise PR templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates?utm_source=&utm_content=fix-pr-template) > - 🛠 [Adjust upgrade PR settings](https://app.snyk.io/org/varant-zlai/project/f4bdc116-d05b-4937-96b5-b1f9a02872e5/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 🔕 [Ignore this dependency or unsubscribe from future upgrade PRs](https://app.snyk.io/org/varant-zlai/project/f4bdc116-d05b-4937-96b5-b1f9a02872e5/settings/integration?pkg=echarts&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades) [//]: # 'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"echarts","from":"5.5.1","to":"5.6.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"7c748a0b-162a-447c-bd9a-9349e0a43d77","prPublicId":"7c748a0b-162a-447c-bd9a-9349e0a43d77","packageManager":"npm","priorityScoreList":[],"projectPublicId":"f4bdc116-d05b-4937-96b5-b1f9a02872e5","projectUrl":"https://app.snyk.io/org/varant-zlai/project/f4bdc116-d05b-4937-96b5-b1f9a02872e5?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":2,"publishedDate":"2024-12-28T07:21:42.839Z"},"vulns":[]}' Co-authored-by: snyk-bot <[email protected]>

zhiqingchen · 2025-04-19T06:54:42Z

Because PR has been revoked, the problem still exists. Looking forward to the improvement in v6.

mrginglymus · 2025-07-30T08:24:01Z

@100pah 6.0.0 is out and no bump to tslib :(

xylplm · 2025-09-19T14:09:56Z

@Ovilia Since it is already 6.0, the previous legacy version issue should also be resolved。

Relax tslib requirement specifier

c939973

echarts-bot bot added PR: awaiting review PR: doc unchanged PR: first-time contributor labels Nov 7, 2024

pull-request-size bot added the size/XS label Nov 7, 2024

mrginglymus mentioned this pull request Nov 7, 2024

Relax tslib requirement specifier ecomfe/zrender#1097

Merged

Ovilia approved these changes Nov 8, 2024

View reviewed changes

echarts-bot bot removed the PR: awaiting review label Nov 8, 2024

Ovilia merged commit 18f8ea3 into apache:master Nov 8, 2024
2 checks passed

mrginglymus deleted the relax-tslib branch November 8, 2024 08:12

Ovilia mentioned this pull request Nov 13, 2024

chore: revert ts version #20509

Merged

8 tasks

zhiqingchen mentioned this pull request Apr 19, 2025

[react native 0.79] Cannot read property '__extends' of undefined wuba/react-native-echarts#239

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Relax tslib requirement specifier #20485

Relax tslib requirement specifier #20485

mrginglymus commented Nov 7, 2024 •

edited

Loading

Uh oh!

echarts-bot bot commented Nov 7, 2024

Uh oh!

github-actions bot commented Nov 8, 2024

Uh oh!

Uh oh!

echarts-bot bot commented Nov 8, 2024

Uh oh!

100pah commented Nov 12, 2024

Uh oh!

mrginglymus commented Nov 12, 2024

Uh oh!

100pah commented Nov 13, 2024 •

edited

Loading

Uh oh!

zhiqingchen commented Apr 19, 2025

Uh oh!

mrginglymus commented Jul 30, 2025

Uh oh!

xylplm commented Sep 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Relax tslib requirement specifier #20485

Relax tslib requirement specifier #20485

Conversation

mrginglymus commented Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Brief Information

What does this PR do?

Fixed issues

Details

Before: What was the problem?

After: How does it behave after the fixing?

Document Info

Misc

ZRender Changes

Related test cases or examples to use the new APIs

Others

Merging options

Other information

Uh oh!

echarts-bot bot commented Nov 7, 2024

Uh oh!

github-actions bot commented Nov 8, 2024

Uh oh!

Uh oh!

echarts-bot bot commented Nov 8, 2024

Uh oh!

100pah commented Nov 12, 2024

Uh oh!

mrginglymus commented Nov 12, 2024

Uh oh!

100pah commented Nov 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhiqingchen commented Apr 19, 2025

Uh oh!

mrginglymus commented Jul 30, 2025

Uh oh!

xylplm commented Sep 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mrginglymus commented Nov 7, 2024 •

edited

Loading

100pah commented Nov 13, 2024 •

edited

Loading