Skip to content

[Windows] Fixed the flyout content width not being set correctly after updating to WinUI SDK 1.7 #28996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2025
Merged

[Windows] Fixed the flyout content width not being set correctly after updating to WinUI SDK 1.7 #28996

merged 2 commits into from
Apr 16, 2025

Conversation

Tamilarasan-Paranthaman
Copy link
Contributor

@Tamilarasan-Paranthaman Tamilarasan-Paranthaman commented Apr 15, 2025 •
edited
Loading

Root Cause of the issue

  • In WinUI SDK 1.7, it seems that if the PaneContentGrid width is not explicitly set, it takes on the desired width of its child.

Description of Change

  • I set the flyout's OpenPaneLength to the PaneContentGrid width, which resolves the issue. Additionally, due to the current changes, the measure logic is now invoked only once during the initial load and not again when the flyout is opened. To ensure the view is properly arranged during the initial load, I removed the !ShellView.IsPaneOpen condition check in the MeasureOverride method.

Issues Fixed

Fixes #28991

Tested the behaviour in the following platforms

  • Windows
  • iOS
  • Android
  • Mac

Screenshot

Before Fix After Fix
Before-Fix.mp4
After-Fix.mp4

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Apr 15, 2025
@sheiksyedm sheiksyedm added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Apr 15, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey there @@Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

MartyIX
MartyIX reviewed Apr 15, 2025
View reviewed changes
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman marked this pull request as ready for review April 15, 2025 10:02
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman requested a review from a team as a code owner April 15, 2025 10:02
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman requested review from StephaneDelcroix and tj-devel709 and removed request for a team April 15, 2025 10:02
jsuarezruiz
jsuarezruiz requested changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could include a golden test validating the result comparing a snapshot?

@PureWeen PureWeen added this to the .NET 9 SR7 milestone Apr 15, 2025
@PureWeen
Copy link
Member

/azp run MAUI-UITests-public

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@PureWeen
Copy link
Member

Could include a golden test validating the result comparing a snapshot?

This fixes tests that are already failing
So, I don't think we need to add any additional UITests

@PureWeen PureWeen merged commit 2464d18 into dotnet:inflight/current Apr 16, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in MAUI SDK Ongoing Apr 16, 2025
PureWeen pushed a commit that referenced this pull request Apr 16, 2025
@Tamilarasan-Paranthaman @PureWeen
[Windows] Fixed the flyout content width not being set correctly afte…
9576008 
…r updating to WinUI SDK 1.7 (#28996)

* Fixed flyout content width issue

* Updated details
NanthiniMahalingam pushed a commit to NanthiniMahalingam/maui that referenced this pull request Apr 17, 2025
@Tamilarasan-Paranthaman @NanthiniMahalingam
[Windows] Fixed the flyout content width not being set correctly afte…
380073c 
…r updating to WinUI SDK 1.7 (dotnet#28996)

* Fixed flyout content width issue

* Updated details
github-actions bot pushed a commit that referenced this pull request Apr 18, 2025
@Tamilarasan-Paranthaman @PureWeen
[Windows] Fixed the flyout content width not being set correctly afte…
7ceae37 
…r updating to WinUI SDK 1.7 (#28996)

* Fixed flyout content width issue

* Updated details
@PureWeen PureWeen mentioned this pull request Apr 22, 2025
Merged
PureWeen added a commit that referenced this pull request Apr 23, 2025
@PureWeen
[2025/04/21] Candidate - In Flight Branch (#29037)
9b3c784 
### Description of Change

## .NET MAUI Release Notes - Inflight/Candidate

## What's Changed

### MAUI Product Fixes
* Fix CarouselView layout SR6 regressions by @albyrock87 in
#29035
* Revert "[Android] picker - focus/unfocus events (#28122)" by @PureWeen
in https://github.com/dotnet/maui/pull/1fb5164929
* [Windows] Fixed the flyout content width not being set correctly after
updating to WinUI SDK 1.7 by @Tamilarasan-Paranthaman in
#28996
* [Android] picker - focus/unfocus events by @kubaflo in
#28122
* [XC] add IRootObjectProvider by @StephaneDelcroix in
#28310
* [iOS] Fix for the File.ContentType from MediaPicker not being in valid
MIME format by @SyedAbdulAzeemSF4852 in
#28842
* [Android] Fixed the Incorrect Text Color Applied to Selected Tab in
TabbedPage by @Ahamed-Ali in #28844
* [iOS] Fix FlyoutPage does not respond to changes in the
FlyoutLayoutBehavior property by @devanathan-vaithiyanathan in
#28884
* [Android] Fixed ScalingCanvas.SetBlur not working by
@NirmalKumarYuvaraj in #28911
* [iOS] - Resolved Proper Rendering of Dynamic Header/Footer Updates in
CV2 by @prakashKannanSf3972 in #28641
* [iOS] Fixed the TargetInvocationException Occurs When Selecting
Header/Footer After Changing ItemsLayout in CV2 by @Ahamed-Ali in
#28890
* [Windows] - Fix Visual State Issue with Picker TextColor After
Navigation by @prakashKannanSf3972 in
#28746

### Dependency Updates
* [Windows] Upgrade to Windows App SDK 1.7 by @MartyIX in
#28499

### Testing
* [Testing] Feature Matrix UITest Cases for CollectionView EmptyView
Feature by @NafeelaNazhir in #28679
* Fixed Test case failure in PR 29037 - [2025/04/21] Candidate by
@HarishKumarSF4517 in #29049

**Full Changelog**:
main...inflight/candidate


For more information about inflight process check
https://github.com/dotnet/maui/wiki/Inflight-Branch-Process
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz requested changes

@PureWeen PureWeen PureWeen approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

+1 more reviewer

@MartyIX MartyIX MartyIX left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/windows
Projects
MAUI SDK Ongoing
Status: Done
Milestone
.NET 9 SR7
Development

Successfully merging this pull request may close these issues.
5 participants
@Tamilarasan-Paranthaman @PureWeen @MartyIX @jsuarezruiz @sheiksyedm