[Android] Picker - focus/unfocus events #28122
Merged
+84
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubaflo
added
platform/android
area-controls-picker
kubaflo
force-pushed
the
Picker-Focused/Unfocused-Events-Do-Not-Fire-on-Android-
branch
from
d53d4d5 to
d1a6b33
Compare
|
BTW bumping this time and date picker focus/unfocus events related PR of mine :) |
MartyIX
reviewed
Mar 2, 2025
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28121.cs
Outdated
Show resolved
Hide resolved
kubaflo
force-pushed
the
Picker-Focused/Unfocused-Events-Do-Not-Fire-on-Android-
branch
from
d1a6b33 to
abf3a49
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Mar 3, 2025
| @@ -0,0 +1,33 @@ | |||
| #if ANDROID | |||
There was a problem hiding this comment.
While the fix is for Android, I think the test could run on all the platforms and verify the same events everywhere. Could we remove the compilation directive?
There was a problem hiding this comment.
It won't work because even with such addition
#if IOS
App.Click("Done");
#endifthe iOS picker won't close
kubaflo
force-pushed
the
Picker-Focused/Unfocused-Events-Do-Not-Fire-on-Android-
branch
from
abf3a49 to
e7ddc66
Compare
|
This also fixes the issue #8546 |
rmarinho
approved these changes
Apr 11, 2025
|
/rebase |
github-actions
bot
force-pushed
the
Picker-Focused/Unfocused-Events-Do-Not-Fire-on-Android-
branch
from
e7ddc66 to
d626176
Compare
PureWeen
force-pushed
the
inflight/current
branch
from
717a197 to
be43be9
Compare
github-project-automation
bot
moved this from Ready To Review
to Done
in MAUI SDK Ongoing
PureWeen
pushed a commit
that referenced
this pull request
Apr 16, 2025
|
I'm reverting this PR because it breaks when using the keyboard If you use an attached keyboard the picker keeps opening infinitely and then crashes. |
NanthiniMahalingam
pushed a commit
to NanthiniMahalingam/maui
that referenced
this pull request
Apr 17, 2025
NanthiniMahalingam
pushed a commit
to NanthiniMahalingam/maui
that referenced
this pull request
Apr 17, 2025
This reverts commit dfeadeb.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 18, 2025
This reverts commit dfeadeb.
PureWeen
added a commit
that referenced
this pull request
Apr 23, 2025
### Description of Change ## .NET MAUI Release Notes - Inflight/Candidate ## What's Changed ### MAUI Product Fixes * Fix CarouselView layout SR6 regressions by @albyrock87 in #29035 * Revert "[Android] picker - focus/unfocus events (#28122)" by @PureWeen in https://github.com/dotnet/maui/pull/1fb5164929 * [Windows] Fixed the flyout content width not being set correctly after updating to WinUI SDK 1.7 by @Tamilarasan-Paranthaman in #28996 * [Android] picker - focus/unfocus events by @kubaflo in #28122 * [XC] add IRootObjectProvider by @StephaneDelcroix in #28310 * [iOS] Fix for the File.ContentType from MediaPicker not being in valid MIME format by @SyedAbdulAzeemSF4852 in #28842 * [Android] Fixed the Incorrect Text Color Applied to Selected Tab in TabbedPage by @Ahamed-Ali in #28844 * [iOS] Fix FlyoutPage does not respond to changes in the FlyoutLayoutBehavior property by @devanathan-vaithiyanathan in #28884 * [Android] Fixed ScalingCanvas.SetBlur not working by @NirmalKumarYuvaraj in #28911 * [iOS] - Resolved Proper Rendering of Dynamic Header/Footer Updates in CV2 by @prakashKannanSf3972 in #28641 * [iOS] Fixed the TargetInvocationException Occurs When Selecting Header/Footer After Changing ItemsLayout in CV2 by @Ahamed-Ali in #28890 * [Windows] - Fix Visual State Issue with Picker TextColor After Navigation by @prakashKannanSf3972 in #28746 ### Dependency Updates * [Windows] Upgrade to Windows App SDK 1.7 by @MartyIX in #28499 ### Testing * [Testing] Feature Matrix UITest Cases for CollectionView EmptyView Feature by @NafeelaNazhir in #28679 * Fixed Test case failure in PR 29037 - [2025/04/21] Candidate by @HarishKumarSF4517 in #29049 **Full Changelog**: main...inflight/candidate For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #28121
Fixes #21704
Fixes #19739
Screen.Recording.2025-03-01.at.20.22.09.mov
Screen.Recording.2025-03-01.at.20.21.02.mov