Skip to content

[Windows] Upgrade to Windows App SDK 1.7 #28499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MartyIX
Copy link
Contributor

@MartyIX MartyIX commented Mar 19, 2025

Description of Change

Upgrade Windows App SDK from 1.6 to 1.7. See release notes and GitHub release notes:

I'm not sure what the plans regarding upgrading are1. I just noticed that it seems much easier to upgrade than from 1.5 to 1.6.

Footnotes

  1. Should it be done in .NET 9 servicing or in .NET 10?

@MartyIX MartyIX requested a review from a team as a code owner March 19, 2025 08:30
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Mar 19, 2025
@PureWeen
Copy link
Member

/azp run MAUI-public

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfversluis jfversluis added this to the .NET 10.0-preview6 milestone Mar 19, 2025
@jfversluis jfversluis self-assigned this Mar 19, 2025
@mattleibow mattleibow added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Mar 19, 2025
@mattleibow
Copy link
Member

Everything is broken:

error : C:\a_work_temp\test-dir\BuildPackagedma776709161\Properties\launchSettings.json does not contain a profile with commandName 'MsixPackage'. To debug a packaged single-project MSIX solution, a profile with command name MsixPackage in launchSettings.json is required. For more information, visit https://aka.ms/winappsdk.singleproj. [C:\a_work_temp\test-dir\BuildPackagedma776709161\BuildPackagedma776709161.csproj::TargetFramework=net9.0-windows10.0.19041.0]
BuildPackagedma776709161 -> C:\a_work_temp\test-dir\BuildPackagedma776709161\bin\Debug\net9.0-android\BuildPackagedma776709161.dll

@mattleibow
Copy link
Member

Looks like this happens with packaged apps, let me see

@mattleibow
Copy link
Member

It looks like it is the tests that switch the build from Packaged to Unpackaged in the csproj, but not also the launchSettings.json.

Are you also able to add some code in those places that do a find/replace of MsixPackage -> Project when doing things?

For example, this just changes the csproj, but we need to add also one for the launchSettings.json

"<WindowsPackageType>None</WindowsPackageType>",

@mattleibow
Copy link
Member

@jfversluis any reason for .NET 10 Pre 6 as opposed to much sooner?

I think this is also nice to get into .NET 9 if there are any improvements/bugfixes?

@jfversluis
Copy link
Member

@mattleibow I totally meant to click net9 SR6 😄

@mattleibow mattleibow changed the base branch from main to inflight/current March 19, 2025 18:20
@mattleibow mattleibow modified the milestones: .NET 9 SR6, Backlog Mar 19, 2025
@mattleibow mattleibow changed the base branch from inflight/current to main March 19, 2025 18:21
@mattleibow
Copy link
Member

/azp run

@mattleibow
Copy link
Member

mattleibow commented Mar 19, 2025

If this starts to look very green, then we can rebase and merge into the inflight/current branch.

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@mattleibow mattleibow modified the milestones: Backlog, .NET 9 SR6 Mar 19, 2025
@MartyIX
Copy link
Contributor Author

MartyIX commented Mar 20, 2025

@mattleibow I did

dotnet cake --target=dotnet --configuration="Release" --verbosity=diagnostic
dotnet cake --target=dotnet-local-workloads --verbosity=diagnostic

and then ran Windows template tests in my Visual Studio. I can see:

image

So tests pass for me. I ignored maui-blazor tests for now.

-> I'm not exactly sure why tests pass on my end and it fails when running on CI.

@MartyIX
Copy link
Contributor Author

MartyIX commented Mar 20, 2025

Ok, even razor tests pass:

image

@MartyIX MartyIX force-pushed the feature/2025-03-19-WinAppSDK-1.7 branch from d5d4392 to acbb49d Compare March 22, 2025 11:37
@MartyIX
Copy link
Contributor Author

MartyIX commented Mar 22, 2025

@mattleibow I tried to rebase as there was a change in global.json recently

@MartyIX
Copy link
Contributor Author

MartyIX commented Apr 9, 2025

Any news here?

Any help is welcome.

@MartyIX MartyIX force-pushed the feature/2025-03-19-WinAppSDK-1.7 branch from bf73811 to d0f7007 Compare April 10, 2025 06:19
@MartyIX
Copy link
Contributor Author

MartyIX commented Apr 10, 2025

Unfortunately, even with 1.7.1, I can see the same behavior for ShellFlowDirectionUpdate (Issue17057 -- "Shell FlowDirection not updating properly")

image

@PureWeen PureWeen changed the base branch from main to inflight/current April 11, 2025 15:37
@PureWeen PureWeen merged commit f20da78 into dotnet:inflight/current Apr 11, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from Todo to Done in MAUI SDK Ongoing Apr 11, 2025
@MartyIX MartyIX deleted the feature/2025-03-19-WinAppSDK-1.7 branch April 11, 2025 15:38
PureWeen pushed a commit that referenced this pull request Apr 16, 2025
* Update to Windows App SDK 1.7

https://github.com/microsoft/microsoft-ui-xaml/releases/tag/winui3/release/1.7.0

* nits

* Update Directory.Build.targets

* Upgrade 1.7.0 to 1.7.1

---------

Co-authored-by: Matthew Leibowitz <[email protected]>
sheiksyedm pushed a commit to sheiksyedm/maui that referenced this pull request Apr 17, 2025
* Update to Windows App SDK 1.7

https://github.com/microsoft/microsoft-ui-xaml/releases/tag/winui3/release/1.7.0

* nits

* Update Directory.Build.targets

* Upgrade 1.7.0 to 1.7.1

---------

Co-authored-by: Matthew Leibowitz <[email protected]>
NanthiniMahalingam pushed a commit to NanthiniMahalingam/maui that referenced this pull request Apr 17, 2025
* Update to Windows App SDK 1.7

https://github.com/microsoft/microsoft-ui-xaml/releases/tag/winui3/release/1.7.0

* nits

* Update Directory.Build.targets

* Upgrade 1.7.0 to 1.7.1

---------

Co-authored-by: Matthew Leibowitz <[email protected]>
github-actions bot pushed a commit that referenced this pull request Apr 18, 2025
* Update to Windows App SDK 1.7

https://github.com/microsoft/microsoft-ui-xaml/releases/tag/winui3/release/1.7.0

* nits

* Update Directory.Build.targets

* Upgrade 1.7.0 to 1.7.1

---------

Co-authored-by: Matthew Leibowitz <[email protected]>
PureWeen added a commit that referenced this pull request Apr 23, 2025
### Description of Change

## .NET MAUI Release Notes - Inflight/Candidate

## What's Changed

### MAUI Product Fixes
* Fix CarouselView layout SR6 regressions by @albyrock87 in
#29035
* Revert "[Android] picker - focus/unfocus events (#28122)" by @PureWeen
in https://github.com/dotnet/maui/pull/1fb5164929
* [Windows] Fixed the flyout content width not being set correctly after
updating to WinUI SDK 1.7 by @Tamilarasan-Paranthaman in
#28996
* [Android] picker - focus/unfocus events by @kubaflo in
#28122
* [XC] add IRootObjectProvider by @StephaneDelcroix in
#28310
* [iOS] Fix for the File.ContentType from MediaPicker not being in valid
MIME format by @SyedAbdulAzeemSF4852 in
#28842
* [Android] Fixed the Incorrect Text Color Applied to Selected Tab in
TabbedPage by @Ahamed-Ali in #28844
* [iOS] Fix FlyoutPage does not respond to changes in the
FlyoutLayoutBehavior property by @devanathan-vaithiyanathan in
#28884
* [Android] Fixed ScalingCanvas.SetBlur not working by
@NirmalKumarYuvaraj in #28911
* [iOS] - Resolved Proper Rendering of Dynamic Header/Footer Updates in
CV2 by @prakashKannanSf3972 in #28641
* [iOS] Fixed the TargetInvocationException Occurs When Selecting
Header/Footer After Changing ItemsLayout in CV2 by @Ahamed-Ali in
#28890
* [Windows] - Fix Visual State Issue with Picker TextColor After
Navigation by @prakashKannanSf3972 in
#28746

### Dependency Updates
* [Windows] Upgrade to Windows App SDK 1.7 by @MartyIX in
#28499

### Testing
* [Testing] Feature Matrix UITest Cases for CollectionView EmptyView
Feature by @NafeelaNazhir in #28679
* Fixed Test case failure in PR 29037 - [2025/04/21] Candidate by
@HarishKumarSF4517 in #29049

**Full Changelog**:
main...inflight/candidate


For more information about inflight process check
https://github.com/dotnet/maui/wiki/Inflight-Branch-Process
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions community ✨ Community Contribution partner/syncfusion/review platform/windows
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants