Skip to content

feat!: Migrate Modal to Svelte 5 #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 9, 2025
Merged

feat!: Migrate Modal to Svelte 5 #708

merged 12 commits into from
Sep 9, 2025

Conversation

@AntonioVentilii
Copy link
Contributor

Motivation

Migrating component Modal to Svelte 5.

Breaking Changes

The interface changes:

  • The slots title, headerLeft, headerRight, subTitle and footer are migrated to Snippet.
  • No event nnsClose bubbling up anymore, use the prop onClose that receives the callback function.
  • No event introend bubbling up anymore, use the prop onIntroend that receives the callback function.
  • No event click bubbling up anymore, use the prop onClick that receives the callback function.

@AntonioVentilii AntonioVentilii requested review from a team as code owners September 9, 2025 13:52
@AntonioVentilii AntonioVentilii changed the title feat: Migrate Modal to Svelte 5 feat!: Migrate Modal to Svelte 5 Sep 9, 2025
@AntonioVentilii AntonioVentilii marked this pull request as draft September 9, 2025 13:54
@AntonioVentilii AntonioVentilii marked this pull request as ready for review September 9, 2025 15:41
peterpeterparker
peterpeterparker approved these changes Sep 9, 2025
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!!!

@AntonioVentilii AntonioVentilii enabled auto-merge (squash) September 9, 2025 17:56
@AntonioVentilii AntonioVentilii merged commit bc4c842 into main Sep 9, 2025
14 checks passed
@AntonioVentilii AntonioVentilii deleted the feat/Migrate-Modal-to-Svelte-5 branch September 9, 2025 22:36
This was referenced Sep 10, 2025
Merged
Closed
Merged
AntonioVentilii added a commit to dfinity/oisy-wallet that referenced this pull request Sep 11, 2025
@AntonioVentilii
build(frontend): Bump gix-components to next (#8780)
6a83d54 
# Motivation

With PR dfinity/gix-components#708,
`gix-components` has migrated `Modal` to Svelte 5. Since it is quite a
breaking change and that component is used throughout the code, we adapt
it here in a separate PR using the `@next` version.
github-merge-queue bot pushed a commit to dfinity/nns-dapp that referenced this pull request Sep 11, 2025
@AntonioVentilii
build: Bump gix-components to next (#7337)
7535bc6 
# Motivation

With PR dfinity/gix-components#708,
`gix-components` has migrated `Modal` to Svelte 5. Since it is quite a
breaking change and that component is used throughout the code, we adapt
it here in a separate PR using the `@next` version.
github-merge-queue bot pushed a commit to dfinity/nns-dapp that referenced this pull request Sep 12, 2025
@AntonioVentilii
build: Bump gix-components to next (#7337)
a3e8a73 
# Motivation

With PR dfinity/gix-components#708,
`gix-components` has migrated `Modal` to Svelte 5. Since it is quite a
breaking change and that component is used throughout the code, we adapt
it here in a separate PR using the `@next` version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterpeterparker peterpeterparker peterpeterparker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AntonioVentilii @peterpeterparker