Skip to content

Conversation

@AntonioVentilii
Copy link
Collaborator

@AntonioVentilii AntonioVentilii commented Sep 10, 2025

Motivation

With PR dfinity/gix-components#708, gix-components has migrated Modal to Svelte 5. Since it is quite a breaking change and that component is used throughout the code, we adapt it here in a separate PR using the @next version.

Copilot AI review requested due to automatic review settings September 10, 2025 09:52
@AntonioVentilii AntonioVentilii requested a review from a team as a code owner September 10, 2025 09:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the gix-components library to use the next version that includes the migration of the Modal component to Svelte 5, adapting all Modal usages throughout the codebase to use the new API.

  • Updates gix-components to ^8.0.0-next-2025-09-10 in package.json
  • Migrates Modal component usage from Svelte 4 event handlers to Svelte 5 props
  • Converts slot-based title patterns to Svelte 5 snippet syntax

Reviewed Changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 1 comment.

File Description
package.json Updates gix-components version to next pre-release
Multiple Modal components Converts on:nnsClose to onClose prop and slot="title" to {#snippet title()}

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@AntonioVentilii AntonioVentilii merged commit 6a83d54 into main Sep 11, 2025
69 checks passed
@AntonioVentilii AntonioVentilii deleted the build-frontend/Bump-gix-components-to-next branch September 11, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants