Skip to content

Conversation

@AntonioVentilii
Copy link
Contributor

Motivation

With PR dfinity/gix-components#708, gix-components has migrated Modal to Svelte 5. Since it is quite a breaking change and that component is used throughout the code, we adapt it here in a separate PR using the @next version.

@AntonioVentilii AntonioVentilii marked this pull request as ready for review September 10, 2025 11:33
@AntonioVentilii AntonioVentilii requested a review from a team as a code owner September 10, 2025 11:33
@AntonioVentilii AntonioVentilii marked this pull request as draft September 10, 2025 14:28
@AntonioVentilii AntonioVentilii marked this pull request as ready for review September 11, 2025 08:17
@AntonioVentilii AntonioVentilii marked this pull request as draft September 11, 2025 08:22
@AntonioVentilii AntonioVentilii marked this pull request as ready for review September 11, 2025 14:04
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks a lot!

@AntonioVentilii AntonioVentilii added this pull request to the merge queue Sep 11, 2025
github-merge-queue bot pushed a commit that referenced this pull request Sep 11, 2025
# Motivation

With PR dfinity/gix-components#708,
`gix-components` has migrated `Modal` to Svelte 5. Since it is quite a
breaking change and that component is used throughout the code, we adapt
it here in a separate PR using the `@next` version.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2025
@AntonioVentilii AntonioVentilii added this pull request to the merge queue Sep 12, 2025
Merged via the queue into main with commit a3e8a73 Sep 12, 2025
36 checks passed
@AntonioVentilii AntonioVentilii deleted the build/Bump-gix-components-to-next branch September 12, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants