update for cedar#921 #151
Merged
update for cedar#921 #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Disselkoen <[email protected]>
shaobo-he-aws
approved these changes
May 29, 2024
khieta
approved these changes
May 29, 2024
khieta
reviewed
May 29, 2024
CedarJavaFFI/src/objects.rs
Outdated
| /// Decode the object into its string representation | ||
| pub fn get_string_repr(&self) -> String { | ||
| self.id.to_string() | ||
| self.id.as_ref().to_string() |
There was a problem hiding this comment.
Why not .escaped()? That would have been the original behavior, right?
There was a problem hiding this comment.
True, and I can change it. I thought that perhaps folks manipulating the string in Java might expect to manipulate the unescaped string. But I suppose no one has complained about the current behavior
There was a problem hiding this comment.
No strong preference, I was just wondering if the behavior change was intentional. I think both options are reasonable, but might be better stick with the status quo 🤷♀️
There was a problem hiding this comment.
Changed to .escaped()
Signed-off-by: Craig Disselkoen <[email protected]>
shaobo-he-aws
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
cedar-policy/cedar#921