Skip to content

update for cedar#921 #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2024
Merged

update for cedar#921 #151

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7402739
update for cedar#921
cdisselkoen May 29, 2024
cacbee4
escaped
cdisselkoen May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CedarJavaFFI/src/objects.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ impl<'a> JEntityId<'a> {

/// Decode the object into its string representation
pub fn get_string_repr(&self) -> String {
self.id.to_string()
self.id.as_ref().to_string()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not .escaped()? That would have been the original behavior, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, and I can change it. I thought that perhaps folks manipulating the string in Java might expect to manipulate the unescaped string. But I suppose no one has complained about the current behavior

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong preference, I was just wondering if the behavior change was intentional. I think both options are reasonable, but might be better stick with the status quo 🤷‍♀️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to .escaped()

}
}

Expand Down