remove Display for EntityId in favor of explicit .escaped() and .as_ref()
#921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ef() Signed-off-by: Craig Disselkoen <[email protected]>
khieta
approved these changes
May 29, 2024
There was a problem hiding this comment.
Lgtm. @andrewbanchich does this change address your concerns?
|
CI failures appear to be caused by a missing |
Yep, perfect! Thanks! |
aaronjeline
approved these changes
May 29, 2024
Signed-off-by: Craig Disselkoen <[email protected]>
shaobo-he-aws
approved these changes
May 29, 2024
This was referenced May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Removes
DisplayfromEntityId, as it was unclear whether it should produce an escaped or unescaped representation. Instead, users should choose the explicit.escaped()for the former, or.as_ref()for the latter. Added doc comments to this effect.Issue #, if available
Fixes #884
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., changes to the signature of an existing API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):cedar-spec, and how you have tested that your updates are correct.)